On 2017/12/06 12:46, Alexander Bluhm wrote:
> On Wed, Nov 29, 2017 at 09:02:07PM +0100, Stefan Sperling wrote:
> > > > + void loadbuf(text,len)const char*const text;const size_t len;
> > > > +-{ if(buffilled+len>buflen) /* buf can't hold the
> > > > text */
> > > > ++{ while(buffilled+len>buflen) /* buf can't hold the
> > > > text */
> > > > + buf=realloc(buf,buflen+=Bsize);
> > > > + tmemmove(buf+buffilled,text,len);buffilled+=len;
> > > > + }
> > >
> > > Is this the real coding style ?!?!? seriously ?
> > >
> >
> > Yes. Quoting guenther@:
> >
> > "Any whitespace you see is either left-indent, right-indent,
> > or syntactically required."
>
> Any other comments beside the upstream coding style?
>
> Otherwise I would just commit it.
>
> bluhm
>
OK for the fix. But guenther@'s comment from 2015 still stands -
"Executive summary: delete the procmail port; the code is not safe and
should not be used as a basis for any further work."
(https://marc.info/?l=openbsd-ports&m=141634350915839&w=2)
AFAIK the other work necessary in the ports tree to do this has now
been done.
