On Tue, Dec 05, 2017 at 10:43:51PM +0100, Antoine Jacoutot wrote: > On Tue, Dec 05, 2017 at 09:39:44PM +0000, Klemens Nanni wrote: > > On Tue, Dec 05, 2017 at 07:17:33AM +0800, Helg wrote: > > > Hi ports@, > > > > > > Update from 0.4.2 => 0.4.4 > > > > > > I've been working with the developer of fuse-zip to add the FUSE mknod > > > operation. This is now mandatory for FUSE ports on OpenbSD after I > > > removed the incorrect implementation of create from the kernel and > > > libfuse. > > > > > > This version also fixes an "off-by-one" bug that caused fuse-zip to fail > > > with either a Segementation fault of Bus error when copying a sparse > > > file. > > > > > > License has changed from LGPL to GPL. > > > > > > ok? > > I find it confusing to symlink gmake in do-configure instead of > > pre-build or so. In fact, this is only required for the test suite as > > the main Makefile uses $(MAKE). > > > > Attached diff changes that besides adding TEST_TARGET=check (as already > > mentioned by jca@). > > > > I also removed the CVS tag hunk from your PLIST diff. > > > > diff --git a/archivers/fuse-zip/Makefile b/archivers/fuse-zip/Makefile > > index 62e32780149..f6f46c37af8 100644 > > --- a/archivers/fuse-zip/Makefile > > +++ b/archivers/fuse-zip/Makefile > > @@ -2,13 +2,13 @@ > > > > COMMENT = navigate zip archives through FUSE > > > > -DISTNAME = fuse-zip-0.4.2 > > +DISTNAME = fuse-zip-0.4.4 > > > > CATEGORIES = archivers > > > > HOMEPAGE = https://bitbucket.org/agalanin/fuse-zip > > > > -# LGPLv3+ > > +# GPLv3+ > > PERMIT_PACKAGE_CDROM = Yes > > > > WANTLIB += c fuse m ${COMPILER_LIBCXX} z zip > > @@ -23,8 +23,10 @@ FAKE_FLAGS = > > INSTALLPREFIX="${WRKINST}${PREFIX}" > > > > USE_GMAKE = Yes > > > > -do-configure: > > - ln -s ${LOCALBASE}/bin/gmake ${WRKDIR}/bin/make > > +TEST_TARGET = check > > + > > +pre-test: > > + ln -sf ${LOCALBASE}/bin/gmake ${WRKDIR}/bin/make > > Ugly. > Can't you use ${MAKE_PROGRAM} instead? ${LOCALBASE}/bin/${MAKE_PROGRAM} only works for USE_GMAKE=Yes anyway which is just as ugly.
tests/Makefile should simply use/pick up the make program used for the main Makefile.
