On Mon, Nov 20, 2017 at 09:41:31PM +0100, Klemens Nanni wrote:
> On Mon, Nov 20, 2017 at 08:15:13PM +0100, Adam Wolk wrote:
> > On Wed, Nov 08, 2017 at 09:43:01PM +0100, Adam Wolk wrote:
> > > Hi ports@
> > >
> > > attaching a trivial bump for net/corebird
> > > testedo n amd64 current.
> > >
> > > Port changes:
> > > - dropping dependency on librest
> > > - dropping wantlib on soup-gnome
> > > - appdata changed it's dwelling place
> > > - setting HOME for tests and interactive
> > > causing all tests to finally pass
> > >
> > > Feedback, OK's?
> > [...]
> >
> > Corebird 1.7.3 has been recently released with support for 280 characters
> > change on Twitter and a few other tweaks. Updated diff and upstream
> > changelog below:
> > [...]
> Port builds and starts fine for me, I don't have a Twitter account to
> actually test it, though. Still some feedback:
>
> - DESCR's first sentence is missing a full stop
> - HOMEPAGE supports HTTPS
> - SEPARATE_BUILD=Yes can be set
> - TEST and TEST_INTERACTIVE have inconsistent spacing around =
>
updated diff with your suggestions
Index: Makefile
===================================================================
RCS file: /cvs/ports/net/corebird/Makefile,v
retrieving revision 1.17
diff -u -p -r1.17 Makefile
--- Makefile 28 Oct 2017 18:31:41 -0000 1.17
+++ Makefile 20 Nov 2017 21:18:37 -0000
@@ -2,15 +2,14 @@
COMMENT = native Gtk+ Twitter client
-V = 1.5.1
+V = 1.7.3
DISTNAME = corebird-${V}
MASTER_SITES =
https://github.com/baedert/corebird/releases/download/${V}/
-REVISION = 2
EXTRACT_SUFX = .tar.xz
CATEGORIES = net
-HOMEPAGE = http://corebird.baedert.org/
+HOMEPAGE = https://corebird.baedert.org/
MAINTAINER = Adam Wolk <[email protected]>
@@ -25,7 +24,7 @@ WANTLIB += gmodule-2.0 gobject-2.0 graph
WANTLIB += gstreamer-1.0 gstvideo-1.0 gthread-2.0 gtk-3 harfbuzz
WANTLIB += json-glib-1.0 lzma m orc-0.4 pango-1.0 pangocairo-1.0
WANTLIB += pangoft2-1.0 pcre pixman-1 png pthread
-WANTLIB += rest-0.7 soup-2.4 soup-gnome-2.4 sqlite3 ${COMPILER_LIBCXX} xcb
+WANTLIB += soup-2.4 sqlite3 ${COMPILER_LIBCXX} xcb
WANTLIB += xcb-render xcb-shm xml2 z
MODULES = devel/dconf \
@@ -40,7 +39,6 @@ LIB_DEPENDS = databases/sqlite3 \
devel/json-glib \
devel/libsoup>=2.4 \
devel/orc \
- net/librest>=0.7.91 \
multimedia/gstreamer1/core \
multimedia/gstreamer1/plugins-base \
textproc/gspell \
@@ -52,5 +50,13 @@ RUN_DEPENDS = multimedia/gstreamer1/plu
CONFIGURE_STYLE = gnu
USE_GMAKE = Yes
+
+TEST_ENV = HOME=${WRKDIR}/tests
+TEST_IS_INTERACTIVE = x11
+
+SEPARATE_BUILD = Yes
+
+pre-test:
+ mkdir -p ${WRKDIR}/tests/.config/corebird
.include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/net/corebird/distinfo,v
retrieving revision 1.10
diff -u -p -r1.10 distinfo
--- distinfo 20 Jul 2017 23:22:15 -0000 1.10
+++ distinfo 20 Nov 2017 21:18:37 -0000
@@ -1,2 +1,2 @@
-SHA256 (corebird-1.5.1.tar.xz) = 57ZBol4nnYJRygqfou8Rpd02TjaeH6VPVUWCTclt7aA=
-SIZE (corebird-1.5.1.tar.xz) = 676192
+SHA256 (corebird-1.7.3.tar.xz) = y/Qv3xhvXepHxdFx9qbdR6BdDnIaS/1uYbUwaeonjic=
+SIZE (corebird-1.7.3.tar.xz) = 705080
Index: pkg/DESCR
===================================================================
RCS file: /cvs/ports/net/corebird/pkg/DESCR,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 DESCR
--- pkg/DESCR 2 Mar 2016 16:52:57 -0000 1.1.1.1
+++ pkg/DESCR 20 Nov 2017 21:18:37 -0000
@@ -1,4 +1,4 @@
-Corebird is a native Gtk+ Twitter client
+Corebird is a native Gtk+ Twitter client.
Offers native support for multiple accounts, handles media (including
uploads) and doesn't rescroll your timeline on new tweets.
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/net/corebird/pkg/PLIST,v
retrieving revision 1.6
diff -u -p -r1.6 PLIST
--- pkg/PLIST 20 Jul 2017 23:22:15 -0000 1.6
+++ pkg/PLIST 20 Nov 2017 21:18:37 -0000
@@ -1,8 +1,6 @@
@comment $OpenBSD: PLIST,v 1.6 2017/07/20 23:22:15 awolk Exp $
@bin bin/corebird
@man man/man1/corebird.1
-share/appdata/
-share/appdata/org.baedert.corebird.appdata.xml
share/applications/org.baedert.corebird.desktop
share/dbus-1/services/org.baedert.corebird.service
share/glib-2.0/schemas/org.baedert.corebird.gschema.xml
@@ -63,3 +61,5 @@ share/locale/zh_TW/LC_MESSAGES/corebird.
@unexec-delete %D/bin/update-desktop-database
@exec %D/bin/gtk-update-icon-cache -q -t %D/share/icons/hicolor
@unexec-delete %D/bin/gtk-update-icon-cache -q -t %D/share/icons/hicolor
+share/metainfo/
+share/metainfo/org.baedert.corebird.appdata.xml
