On 2017/11/10 11:28, Kevin Lo wrote:
> On Thu, Nov 09, 2017 at 04:13:44PM +0800, Kevin Lo wrote:
> >
> > Hi,
> >
> > Update both libchewing and scim-chewing to 0.5.1.
> > Tested scim and uim on amd64.
> >
> > While here, I would like to take over maintainership of the libchewing.
> >
> > Comments? OK?
>
> Here's the revised diff that removes unneeded MAKE_ENV in
> libchewing's Makefile.
>
> Index: chinese/libchewing/Makefile
> ===================================================================
> RCS file: /cvs/ports/chinese/libchewing/Makefile,v
> retrieving revision 1.9
> diff -u -p -u -p -r1.9 Makefile
> --- chinese/libchewing/Makefile 11 Mar 2016 19:59:12 -0000 1.9
> +++ chinese/libchewing/Makefile 10 Nov 2017 03:22:07 -0000
> @@ -1,24 +1,34 @@
> # $OpenBSD: Makefile,v 1.9 2016/03/11 19:59:12 naddy Exp $
>
> -COMMENT= intelligent phonetic input method library
> +COMMENT = intelligent phonetic input method library
>
> -V = 0.3.3
> -DISTNAME= libchewing-$V
> -PKGNAME= zh-libchewing-$V
> -REVISION = 2
> +V = 0.5.1
> +PKGNAME = zh-${GH_PROJECT}-${V}
>
> -SHARED_LIBS= chewing 0.0 # .3.1
> +GH_ACCOUNT = chewing
> +GH_PROJECT = libchewing
> +GH_TAGNAME = v${V}
They still have a proper uploaded tarball (rather than just the
auto generated ones) in https://github.com/chewing/libchewing/releases ..
Generally it is better to use these because it insulates the port
from any changes in github's infrastructure or from upstream commits
on the tag. (Also the auto-generated files often miss some files
which are included in the proper release tarball - probably not so
important here with the cmake build - but the changelog and autoconf
files aren't included).
> +CONFIGURE_ARGS =-DMAKEINFO=${LOCALBASE}/bin/gmakeinfo \
> + -DCMAKE_SHARED_LINKER_FLAGS="-lc"
Having to specify -lc seems very odd.. Any idea what's going on here?
> -CONFIGURE_STYLE=gnu
> +CFLAGS += -I${LOCALBASE}/include -fno-stack-protector
Is that (-fno-stack-protector) really needed? Tests pass without it..
