SASANO Takayoshi writes:
> A month has passed but there is no response, this is a ping.

Thanks for submitting this. I like it, but would like to see a couple of
minor changes.

> > diff -uNpr fonts.orig/ja-vlgothic-ttf/Makefile fonts/ja-vlgothic-ttf/Makefi
> le

Please send a tarball of these files, as is customary for new ports.

> > +DISTNAME = VLGothic-20141206
> > +PKGNAME =  ja-vlgothic-ttf-201401206

Note the difference of 20141206 vs 201401206; I would use a variable V,
set PKGNAME = vlgothic-$V and rename the port appropriately.

> > --- fonts.orig/ja-vlgothic-ttf/pkg/DESCR    Thu Jan  1 09:00:00 1970
> > +++ fonts/ja-vlgothic-ttf/pkg/DESCR Tue Sep 12 00:48:03 2017
> > @@ -0,0 +1,4 @@
> > +This port provides VLGothic family Japanese TrueType fonts from Vine Linux
> .
> > +
> > +VLGothic
> > +VLPGothic

It would be nice to describe the font itself, like migmix/migu do. Maybe:

"VLGothic and VLPGothic are a Japanese TrueType font family from Vine Linux.
It consists of kanji, kana and alphanumeric characters from the M+ fonts;
some kanji from the Sazanami Gothic font; and remaining kanji produced by
Daisuke Suzuki of Project Vine."

Of course the paragraph should be edited appropriately if incorrect.

-- 
Anthony J. Bentley

Reply via email to