On Sat, Sep 16 2017, Jeremie Courreges-Anglas <[email protected]> wrote: > On Thu, Sep 14 2017, Stuart Henderson <[email protected]> wrote: >> http://www.openwall.com/lists/oss-security/2017/09/14/9 >> >> : "It probably also suffers from most other historical vulnerabilities >> : that are listed for mpg123. We removed it from Debian in 2014, >> : with a recommendation to use the rgain Python package instead: >> : https://tracker.debian.org/pkg/rgain >> : >> : rgain uses libmad or ffmpeg via GStreamer for decoding, so it isn't >> : exactly bug-free either; but those libraries are actively maintained, >> : and when they have vulnerabilities, they'd need to be fixed anyway for >> : the benefit of other packages." >> >> Here's a port of rgain. OK to import? OK to kill mp3gain? > > I have proposed tweaks for rgain: > - run tests against the currently built module, I find this less > error-prone (no need to make reinstall/update) > - s/py-gobject/py-gobject3/, missing dep visible when importing > the rgain.rgcalc module > - skip one test that seems to hang, no idea of the root cause > > > > I can use this against ogg files, but it looks like I'm missing some > gstreamer modules or something... > > ritchie /usr/ports/mystuff/audio/rgain$ pkg_info | grep gstreamer1 > gstreamer1-1.12.2 framework for streaming media > gstreamer1-plugins-base-1.12.2 base elements for GStreamer > gstreamer1-plugins-good-1.12.2p0 good elements for GStreamer > gstreamer1-plugins-ugly-1.12.2 ugly elements for GStreamer > ritchie /usr/ports/mystuff/audio/rgain$ replaygain -r 90 a.mp3 > Checking for Replay Gain information ... > a.mp3: none > Calculating Replay Gain information ... > a.mp3: > Error while calculating gain - GST error: Il manque un greffon dans > votre installation de GStreamer. (gstdecodebin2.c(4600): gboolean > gst_decode_bin_expose(GstDecodeBin *) (): > /GstPipeline:pipeline0/GstDecodeBin:decbin: > no suitable plugins found: > Missing decoder: MPEG-1 Layer 3 (MP3) (audio/mpeg, mpegversion=(int)1, > mpegaudioversion=(int)1, layer=(int)3, rate=(int)44100, channels=(int)2, > parsed=(boolean)true) > )
Installing gstreamer1-plugins-libav helps handle mp3 files, maybe another gstreamer component would help too, I'm no expert here. It would be nice to document this, or just to add gstreamer1-plugins-libav to RUN_DEPENDS. What do you think? This matter can be handled later. ok to import rgain and kill mp3gain. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
