Hi Donovan -- On 8/1/2017 9:28 AM, Donovan Watteau wrote: > Brian Callahan wrote: >> Since CorsixTH doesn't care which version of Lua it uses, and all the >> RDEPS have a lua53 FLAVOR, let's just have CorsixTH use the first Lua >> that cmake finds, which is 5.3 >> >> New tarball attached with that change. >> >> OK? >> >> ~Brian > Hi Brian, > > Ha! I've been working on a CorsixTH port for over two years, but I > always had some bug here or there preventing me for submitting it > (old bugs between SDL2 and ld.so, trying to deal with Lua flavors, > weird crashes...). I was just working on it again, he he. > > (That's why I had submitted an archivers/innoextract port in the > first place, because this way you can buy and play this game without > requiring Windows at all.) > > Your port, like mine, still crashes for me on macppc, though. > It segfaults in THChunkRenderer::decodeChunks(), and I didn't find a > way to fix this. It "runs" on loongson, though, so I guess it's more > of an endianness issue.
Hmm... ok. I don't have macppc hardware anymore. If you find a solution, I'd be happy to commit it (as long as it also gets sent upstream). > Also, first time you start it, if you don't have any ~/.config/CorsixTH > stuff, you'll get a strange Lua strack trace, and you need to restart. > Once ~/.config/CorsixTH appears, this doesn't show up anymore. My port > also has this bug, and I don't know how to fix this either (I'm patching > main.cpp instead of using a wrapper, but this doesn't fix anything... > using Lua 5.1 instead of Lua 5.3 didn't fix anything either). OK, that explains it. We weren't sure what was causing it. I'll try to make a fix. > In case you're interested, the attached file incorporates some small > fixes from my own port (explicit dep on sdl2, make sure Doxygen can't > be picked up if installed, disable checkForUpdates() because bad and > useless code, don't add a hard dep to timidity because it's not built > by default, instead just suggest people to install it if they really > want it like some other ports already do). I don't think this needs an explicit dep on sdl2. I understand why you did it, but I'm taking the approach that this package should match the functionality of the original game, which means audio. While the CorsixTH people seem to think that game audio is optional, I think that's silly. Setting Doxygen to false is probably ok. Update checks are already disabled because we're not using a release tarball, but I intend to switch to the tarballs once the next release is made, so I think that's good to have a patch to disable updates now. If I am reading their wiki correctly, timidity, while "optional," is required to play the background music. I think that matching the functionality of the original game is important, which means playing background music by default. I'm happy to commit the Doxygen change and the turn off updates patch with a bump right now, if that makes sense to someone else. And I'll put on my todo list to track down the lua crash on first boot and hopefully you can track down the endian issues. ~Brian
