On 6/23/2017 7:24 AM, Dmitrij D. Czarkoff wrote: > Brian Callahan <[email protected]> wrote: > >> Run tested it on amd64, works fine. >> Why not do this though: >> >> USE_GMAKE = Yes >> MAKE_FLAGS = CC="${CC}" >> CONFIGURE_STYLE = gnu >> CONFIGURE_ENV = CFLAGS="${CFLAGS} -I${LOCALBASE}/include" \ >> LDFLAGS="${LDFLAGS} -L${LOCALBASE}/lib" >> >> Then it'll de-hardcode gcc, and you can remove those extra CFLAGS+= and >> LDFLAGS= lines. > Basically I define CFLAGS separately because they are also passed to > MAKE_ENV, and then defining LDFLAGS there seems more aestetically > pleasant to me. This approach does not provide any actual benefits in > this case though, so I don't really want to insist on it. > > Regarding MAKE_FLAGS addition: I'd rather avoid unnecessarily polluting > the environment, so patching Makefile.in seems more appropriate to me. >
And I prefer to avoid writing patches, but I'm not gonna insist on it either :) That new version is ok by me too for import. ~Brian
