Re: NEW: sysutils/sunxi-tools

[Marcus Glocker]

On Sun, Jun 11, 2017 at 10:25:23PM +0100, Stuart Henderson wrote:

> On 2017/06/11 22:56, Marcus Glocker wrote:
> > "A collection of command line tools for ARM devices with Allwinner
> > SoCs."
> > 
> > I e.g. need this to flash the SPL and U-Boot to the C.H.I.Ps NAND.
> > 
> > ok?
> 
> Please replace this
> 
> VERSION =       1.4
> GH_ACCOUNT =    linux-sunxi
> GH_PROJECT =    sunxi-tools
> GH_TAGNAME =    v${VERSION}
> PKGNAME =       sunxi-tools-${VERSION}
> 
> with just this
> 
> GH_ACCOUNT =    linux-sunxi
> GH_PROJECT =    sunxi-tools
> GH_TAGNAME =    v1.4
> 
> ...
> 
> BUILD_DEPENDS =         devel/libusb1
> 
> this one should be LIB_DEPENDS, and you're missing WANTLIB
> 
> ...
> 
>         ln -s ${PREFIX}/bin/sunxi-fexc ${PREFIX}/bin/bin2fex
>         ln -s ${PREFIX}/bin/sunxi-fexc ${PREFIX}/bin/fex2bin
> 
> perhaps nitpicking but I'd rather avoid absolute paths in
> symlinks, these could just be
> 
>         ln -s sunxi-fexc ${PREFIX}/bin/bin2fex
>         ln -s sunxi-fexc ${PREFIX}/bin/fex2bin

Thanks for your feedback.  Fixed port attached.

sunxi-tools.tar.gz
Description: application/tar-gz