On 2017/05/27 16:47, Michal Mazurek wrote: > > Bump REVISION. I would also set PKGSPEC so that ports depending on bitlbee > > are tied to the correct version of bitlbee, otherwise for future bitlbee > > updates we'd need to check for any ABI change in the plugin interface and > > bump bitlbee-facebook and any other deps. Like this: > > > > V= 3.5.1 > > DISTNAME= bitlbee-$V > > PKGSPEC= bitlbee-=$V > > REVISION= 0 > > Fixed, attached below. > > > I'd drop "The" and mention "messenger" too e.g. > > > > COMMENT= Facebook Messenger protocol plugin for bitlbee > > This was copy-pasted from the projects homepage, but your version reads > better. > > > Kill the useless static archive (probably "LIBTOOL_FLAGS= > > --tag=disable-static"), > > and probably also @comment the .la file (but check that it works without). > > It works, fixed and attached.
OK for bitlbee. I missed it before, but please change CONFIGURE_STYLE from simple to gnu in bitlbee-facebook, then that's OK too.
