Rafael Sadowski <[email protected]> writes:

> On Tue May 16, 2017 at 12:16:59AM +0000, Mike Burns wrote:
>> Maintainer update of devel/gitsh. Includes quite a few fixes to make it
>> easier to package for BSD.
>> 
>> This release also brings re-arrangement of the files internal to the
>> project, so apologies about the extensive plist diff.
>> 
>> -Mike
>> 
>
> Works fine for me on amd64. Build tested with clang and gcc. Please find
> below a diff with two small tweaks. Use $HOMEPAGE in MASTER_SITES to
> reduce line length in Makefile and add NO_TEST.

NO_TEST should be used if a port doesn't have any test infrastructure
and "make test" results in an error because of this.  By default with
gitsh there is an empty test suite set up by autotools, so please remove
NO_TEST.

No opinion regarding using HOMEPAGE in MASTER_SITES, maybe Mike has
preferences?  (Some people like to have a readable MASTER_SITES.)

> Anyone else?

Apart from NO_TEST, ok jca@

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to