On 2017-02-14 00:53, Jeremie Courreges-Anglas wrote:
Ian McWilliam <[email protected]> writes:
I'm afraid that this diff is not the right direction. The reason why
we
keep using 4.4.5 is that a library was removed between 4.4.5 and 4.4.8,
so the diff as is probably doesn't package without a PLIST change.
Also
the removal of this shared lib means changes in other -stable ports and
a rebuild of the affected packages, instead of a simple upgrade of the
samba packages.
I propose the following diff, which should allow people to use
samba-tool provision --use-ntvfs.
There are bug fixes that have landed in samba-4.4 since 4.4.5, if
people
want to backport them because they break runtime, patches are welcome.
Please test and report.
Index: Makefile
===================================================================
RCS file: /d/cvs/ports/net/samba/Makefile,v
retrieving revision 1.227.2.1
diff -u -p -r1.227.2.1 Makefile
--- Makefile 23 Dec 2016 22:35:36 -0000 1.227.2.1
+++ Makefile 14 Feb 2017 05:45:09 -0000
@@ -15,7 +15,7 @@ PKGNAME-tevent = tevent-${TEVENT_V}
PKGNAME-util = samba-util-${VERSION}
PKGNAME-docs = samba-docs-${VERSION}
-REVISION-main = 0
+REVISION-main = 1
REVISION-ldb = 0
REVISION-tevent = 0
@@ -160,7 +160,8 @@ CONFIGURE_ARGS = --enable-fhs \
--without-regedit \
--without-acl-support \
--without-libarchive \
- --disable-rpath
+ --disable-rpath \
+ --with-ntvfs-fileserver
# XXX Remember to remove --enable-developer, it prints passwords in
logs.
#CONFIGURE_ARGS += --enable-developer
Index: pkg/PLIST-main
===================================================================
RCS file: /d/cvs/ports/net/samba/pkg/PLIST-main,v
retrieving revision 1.34
diff -u -p -r1.34 PLIST-main
--- pkg/PLIST-main 8 Jul 2016 18:39:50 -0000 1.34
+++ pkg/PLIST-main 14 Feb 2017 05:45:09 -0000
@@ -807,6 +807,7 @@ lib/samba/service/ldap.so
lib/samba/service/nbtd.so
lib/samba/service/ntp_signd.so
lib/samba/service/s3fs.so
+lib/samba/service/smb.so
lib/samba/service/web.so
lib/samba/service/winbindd.so
lib/samba/service/wrepl.so
I'm fine with 4.4.5, but there really is no point in enabling ntvfs as
it's broken plain and simple on all 4.4 releases. Considering we have a
workaround for using s3fs with tdb backends (a simple modification to a
python script) i believe it would be much more beneficial to backport
the s3fs workaround rather than enabling a broken file server.
