On Sun, Feb 05, 2017 at 08:59:34PM -0700, Andrew Fresh wrote:
> On Sun, Feb 05, 2017 at 01:36:03PM +0100, Mark Patruck wrote:
> > After base has been updated to perl 5.24.1 and IO::Socket::IP is
> > >=0.37 now, here is an update to www/p5-Mojo 7.23
> >
> > List of changes:
> > https://metacpan.org/changes/distribution/Mojolicious
> >
> > I'm not sure if the post-install stuff (introduced in v1.22) can
> > be removed now as there shouldn't be any users out there with the
> > test certificate under ${PREFIX}/${P5SITE}/Mojo/IOLoop/certs/.
> >
> > As it doesn't hurt, i kept it for now.
>
> I think if this version doesn't install it, it can be removed. That
> said, I don't know the history of that post-install line, so it's hard
> to know what problem it was solving.
>
> However, it does ship with these now, so yes, it seems like a noop, but
> maybe just because it deletes the wrong thing?
>
> Mojolicious-7.23/lib/Mojo/IOLoop/resources/server.crt
> Mojolicious-7.23/lib/Mojo/IOLoop/resources/server.key
The test certificate has been removed from pkg/PLIST few versions
ago and slipped in by accident with p5-Mojo 6.14. Six releases
later we're here...so i think we can drop it now.
> > # www/p5-Mojo 7.23 (tests pass)
>
> I wonder if we want to get more tests running. I don't think it's
> possible to disable IPv6 anymore, or at least unsupported, so maybe add
> the following to "unskip" tests? I'm unclear whether the earlier
> defines are still needed, but these all pass for me.
TEST_IPV6 fails here as usual, the others including
TEST_TLS, TEST_SUBPROCESS
work. I'd leave the existing ones. Is there are way to check
for working IPv6 configuration?
> (I'm not convinced on the multiple MAKE_ENV lines, but I'm not really
> that much a stickler for style here)
I also don't know what's best practice here. Perhaps it's good
to include all available tests, but leave the disabled ones
with a short comment, why they don't work. (f.e. TEST_ONLINE
doesn't work for security reasons)
> ===
>
> MAKE_ENV += TEST_IPV6=Yes
> MAKE_ENV += TEST_TLS=Yes
> MAKE_ENV += TEST_SUBPROCESS=Yes
>
> TEST_DEPENDS += net/p5-IO-Socket-Socks
> MAKE_ENV += TEST_SOCKS=Yes
>
> # Don't test online
> MAKE_ENV += TEST_ONLINE=''
>
> ===
>
>
>
>
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/www/p5-Mojo/Makefile,v
> > retrieving revision 1.28
> > diff -u -p -r1.28 Makefile
> <SNIP>
> > # p5-Mojolicious-Plugin-TtRenderer 1.57
> >
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/textproc/p5-Mojolicious-Plugin-TtRenderer/Makefile,v
> > retrieving revision 1.5
> > diff -u -p -r1.5 Makefile
>
> This really confused
> ftp -o- 'http://marc.info/?l=openbsd-ports&m=148629821021395&q=raw' | patch -E
>
> Could you make sure patches are rooted in a relative directory, or at
> least make a big note at the top? I would sure appreciate it.
>
>
>
> Tests do pass for Mojo and TtRenderer and they pass their tests and
> p5-Mojo's reverse depends (TtRenderer doesn't seem to have any), so:
>
> OK afresh1@ on both, after a decision on removing the certs directory.
>
> (Either way on the additional tests, I just like to enable whatever I can)
>
> --
> andrew - http://afresh1.com
>
> What are the unsurpassable real world weaknesses in OpenBSD,
> that you know of?
> -- Kevin Chadwick <[email protected]>
> Lots of fake people attacking the project on the mailing lists makes
> them a poor resource for users.
> -- Theo de Raadt <[email protected]>
>
--
Mark Patruck ( mark at wrapped.cx )
GPG key 0xF2865E51 / 187F F6D3 EE04 1DCE 1C74 F644 0D3C F66F F286 5E51
http://www.wrapped.cx
