ldistfp fails here:
$ ldistfp some.host
ldistfp 0.1.4 - remote identd fingerprinting tool. -sc/teso
read 94 fingerprints
net_connect: Invalid argument
$
connect(2) fails because the remote address is 255.255.255.255.
The code shows bad compile time warnings:
cc -O2 -pipe -g
-DFINGERPRINTS=\"/usr/local/share/ldistfp/ldistfp-auth-fingerprints\" -c
common.c
cc -O2 -pipe -g
-DFINGERPRINTS=\"/usr/local/share/ldistfp/ldistfp-auth-fingerprints\" -c
network.c
network.c: In function 'net_parseip':
network.c:98: warning: comparison is always false due to limited range of
data type
network.c: In function 'net_peeraddress':
network.c:130: warning: passing argument 3 of 'getpeername' from incompatible
pointer type
network.c: In function 'net_bind':
network.c:275: warning: comparison is always false due to limited range of
data type
cc -O2 -pipe -g
-DFINGERPRINTS=\"/usr/local/share/ldistfp/ldistfp-auth-fingerprints\" -o
ldistfp ldistfp.c common.o network.o
common.o: In function `m_random':
/usr/ports/pobj/ldistfp-0.1.4/ldistfp/src/common.c:154: warning: warning:
random() may return deterministic values, is that what you want?
common.o: In function `ipv4_print':
/usr/ports/pobj/ldistfp-0.1.4/ldistfp/src/common.c:257: warning: warning:
sprintf() is often misused, please use snprintf()
/usr/ports/pobj/ldistfp-0.1.4/ldistfp/src/common.c:253: warning: warning:
strcpy() is almost always misused, please use strlcpy()
There are some assumptions that "unsigned long" is 32 bits, which
doesn't work nicely on 64 bits hosts.
he = gethostbyname(host);
if (he == NULL) {
return (0);
} else {
return (*(unsigned long *) he->h_addr);
}
Non-existent licensing:
PERMIT_PACKAGE_CDROM= no license
The code uses a database of ident daemons signature that is quite
outdated (2001?). Following the url to update the database leads to
a "Connection refused".
Despite what the readme says:
This information can be mapped back to the distribution and it's version
used on this host. Simple but effective, since the identd
authentification service is used almost everywhere and most people don't
know about it's version capabilities.
I doubt that the ident protocol is as widely used nowadays.
ok to remove this port?
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
