Well, if it's all the same to the majority here regarding breakage of
the old names, I like Dmitri's proposal. Here's a patch that puts the
FLAVORs directly in line with upstream.
t.yuuko
On 09/05/16 04:32, [email protected] wrote:
Sun, 04 Sep 2016 22:29:21 -0700 Aioi Yuuko <[email protected]>
I was actually considering that naming convention, with only one minor caveat:
it would break the current flavors. I see four possibilities:
a) keep symquotes and center_tilde, then add in flavors named directly after
the remaining upstream patches
b) custom names for everything
c) all names directly after the upstream patches
d) leave it alone and if anyone wants to really customize, let them edit the
makefile themselves
Discussing just a font for more than ten or so total messages feels like
bikeshedding to me, so if we don't get a conclusive answer soonish, I'll
probably just drop it (i.e. pick option d).
On 4 Sep 2016 4:23 p.m., "Dmitrij D. Czarkoff" <[email protected]> wrote:
Aioi Yuuko <[email protected]> wrote:
-FLAVORS = symquotes centered_tilde
+FLAVORS = symquotes centered_tilde type_dv cyrillic_i distinct_l script_g
high_k
This doesn't make sense to me. There are 10 options and we have 7
FLAVORs with custom (albeit somewhat descriptive) names. I'd rather go
for
FLAVORS = ao2 dv1 ge2 gq2 ij1 ka2 ll2 td1 hi2 br1
and refer to HOMEPAGE for details. In the end, the font's defaults are
rather sane, and those who want to customize their font can probably
pick their preferences themselves.
Hi Aioi,
Point b) was the original direction, I recommend not following this. The
custom names are much longer than the actual upstream variants (flavors).
This would only make sense for a very limited number of flavours, like it
was originally with a). I also recommend following Dmitrij's proposal to
match exactly upstream variants for our flavors, your option c). Agreed?
P.S. I too think the original variants are not ideally named yet wrapping
them in long flavor 'convenience' names is indeed going too far. Plus it
creates added ambiguity and points for mismatch if upstream make changes.
Kind regards,
Anton
Index: Makefile
===================================================================
RCS file: /cvs/ports/fonts/terminus-font/Makefile,v
retrieving revision 1.11
diff -u -p -r1.11 Makefile
--- Makefile 24 Apr 2016 15:44:32 -0000 1.11
+++ Makefile 5 Sep 2016 18:57:05 -0000
@@ -25,15 +25,47 @@ FONTDIR = ${PREFIX}/share/fonts/terminu
USE_GMAKE = Yes
-FLAVORS = symquotes centered_tilde
+FLAVORS = ao2 dv1 ge2 gq2 ij1 ka2 ll2 td1 hi2 br1
FLAVOR ?=
-.if ${FLAVOR:Mcentered_tilde}
-FLAVOR_PATCHES += ${WRKSRC}/alt/td1.diff
+.if ${FLAVOR:Mao2}
+FLAVOR_PATCHES += ${WRKSRC}/alt/ao2.diff
+.endif
+
+.if ${FLAVOR:Mdv1}
+FLAVOR_PATCHES += ${WRKSRC}/alt/dv1.diff
+.endif
+
+.if ${FLAVOR:Mge2}
+FLAVOR_PATCHES += ${WRKSRC}/alt/ge2.diff
.endif
-.if ${FLAVOR:Msymquotes}
+.if ${FLAVOR:Mgq2}
FLAVOR_PATCHES += ${WRKSRC}/alt/gq2.diff
+.endif
+
+.if ${FLAVOR:Mij1}
+FLAVOR_PATCHES += ${WRKSRC}/alt/ij1.diff
+.endif
+
+.if ${FLAVOR:Mka2}
+FLAVOR_PATCHES += ${WRKSRC}/alt/ka2.diff
+.endif
+
+.if ${FLAVOR:Mll2}
+FLAVOR_PATCHES += ${WRKSRC}/alt/ll2.diff
+.endif
+
+.if ${FLAVOR:Mtd1}
+FLAVOR_PATCHES += ${WRKSRC}/alt/td1.diff
+.endif
+
+.if ${FLAVOR:Mhi2}
+FLAVOR_PATCHES += ${WRKSRC}/alt/hi2.diff
+.endif
+
+.if ${FLAVOR:Mbr1}
+FLAVOR_PATCHES += ${WRKSRC}/alt/br1.diff
.endif
PATCH_LIST = patch-* ${FLAVOR_PATCHES}
