Stuart Henderson <[email protected]> writes: > On 2016/05/09 21:18, Jeremie Courreges-Anglas wrote: >> Kristaps Dzonsons <[email protected]> writes: >> @@ -0,0 +1,13 @@ >> +$OpenBSD$ >> +--- random_seed.c.orig Fri Apr 11 02:41:08 2014 >> ++++ random_seed.c Mon May 9 20:43:17 2016 >> +@@ -227,6 +227,9 @@ int json_c_get_random_seed() >> + #if HAVE_RDRAND >> + if (has_rdrand()) return get_rdrand_seed(); >> + #endif >> ++#if HAVE_ARC4RANDOM >> ++ return arc4random(); >> ++#endif >> + #if HAVE_DEV_RANDOM >> + if (has_dev_urandom()) return get_dev_random_seed(); >> + #endif > > Wouldn't it be better to put arc4random before rdrand?
Good question. I figured that if the user has - explicitely - chosen rdrand, then the choice should be respected, even if it's a bit, ahem, stupid. I can change the diff if that's a problem. In the end, this should be discussed with upstream. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
