Am Mittwoch, den 27.04.2016, 00:01 -0700 schrieb steve latif: > Updated diff: > Added proc to the pledge list to deal with the system() in html.c > I missed system() as its not mentioned in the man page for pledge(2) > Including a second diff to add system() to the man page.
As I said, I am not really fluent in analysing the used system calls, so you should probably get additional feedback from somebody else. Having said this, there are still things, that I did find anyway: style in colortree.diff: - line 16: indented by 4 spaces instead of one tab. - line 18: two trailing spaces pledge() in colortree.dif: - If you follow Sebastien's remarks, pledge() should be moved at past the last call of setlocale(). - If you pledge after the opening of the output file (i.e. line 454, after the command-line parsing block), IMHO you can remove the cpath and wpath promises, or did you find them being used anywhere else after initialization? - How confident are you, that colortree will not break those promises?
