On Thu, Nov 05, 2015 at 04:02:19PM +0000, Stuart Henderson wrote:
> > One minor nit: GeoIP{v6}.dat is installed in /var/db/GeoIP under
> > OpenBSD and logswan should use these files
>
> Yes, that needs fixing, actually it should be ${LOCALSTATEDIR}/db/GeoIP.
> Also needs NO_TEST.
ACK, I will address this in the next version and make it configurable,
maybe as a compile time option. This was also mentioned by the logswan
maintainer in Pkgsrc.
> Frederic, it would be nice if it would have a way to output the json file
> somewhere other than ${INPUTFILE}.json - had you considered just writing to
> stdout? (A manual would be nice too ;)
I like the idea of only writing to stdout, it makes the code smaller
and simpler. I will implement that, thanks for the suggestion. Also
thinking about adding support for reading from stdin so logs can be
piped directly to the tool.
And yes, I really need to do some reading on Mandoc :)
Frederic.
