On Wed, Sep 02, 2015 at 09:29:42AM +0200, Theo Buehler wrote:
> With your diff 'make patch' fails because it doesn't remove the patches
> for _find and _diff_options which you upstreamed (did you 'cvs rm' the
> patch files?).

Sorry, I must have at some point swapping between 5.1 5.0.7 for the bug
report and back. The only patches left should be the little bit of
patches/patch-Doc_zsh_texi and
patches/patch-Completion_BSD_Command__bsd_pkg

> The patch below fixes these two points and has the
> following two minor additions which I mentioned in my last mail:
> 
> - replace 'perl -pi -e' with 'sed -i -e'
> - replace ${FULLPKGNAME} with zsh-${V} in PLIST

Looks fine to me. Thanks sthen@ for clarifying on update-plist.

> Tested on amd64.  I will test on powerpc within the next day and will
> report back.



On Wed, Sep 02, 2015 at 12:56:52PM +0200, Theo Buehler wrote:
> It seems that you fixed the C02 test for good.  However, on macppc,
> 'make test' fails the multibyte character test D07 with the following
> output (see also the attached test-macppc.log).  I have LC_CTYPE set
> to en_US.UTF-8, in case that matters.

I seem to be getting the same failure on amd64 (8 spaces after the ZSH).
For some reason it seems that the test suite isn't comparing the output
at all. I'll look into it, but I doubt it's a new regression.

> Moreover, on amd64, a number of tests fail sometimes, but I can't
> reproduce that reliably.

I haven't run into it yet (even with the many times I reran the tests
for the chgrp bug), but I'll keep an eye out.

- Matthew Martin

Reply via email to