Theo Buehler <[email protected]> writes:
> On Sat, Mar 28, 2015 at 02:20:34PM +0100, Theo Buehler wrote:
>> On Sat, Mar 28, 2015 at 12:03:06PM +0100, Christopher Zimmermann wrote:
>> > On Thu, 23 Oct 2014 13:16:52 +0200 Theo Buehler <[email protected]>
>> > wrote:
>> >
>> > > On Wed, Oct 22, 2014 at 04:45:26PM +0200, Pierre-Emmanuel André wrote:
>> > > > Hi,
>> > > >
>> > > > Small diff to update zsh to it's latest version.
>> > > > Tested on @amd64.
>> > > >
>> > > > Comments, ok ?
>> > > > Regards,
>> > > >
>> > > This looks good to me (also amd64). I've been running the updated
>> > > shell for about a day now and didn't encounter any issues.
>> > >
>> > > Two comments:
>> > >
>> > > 1. I went through the entire list on the ports testing guide and
>> > > almost everything seems to be fine. There still is this spurious
>> > > failure of ``make test'' which ends with
>> > >
>> > > **************************************
>> > > 42 successful test scripts, 1 failure, 0 skipped
>> > > **************************************
>> > > *** Error 1 in Test (Makefile:204 'check')
>> > > *** Error 1 in /usr/obj/ports/zsh-5.0.7/zsh-5.0.7 (Makefile:265
>> > > 'check') *** Error 1 in .
>> > > (/usr/ports/infrastructure/mk/bsd.port.mk:2801
>> > > '/usr/obj/ports/zsh-5.0.7/.test_done') *** Error 1
>> > > in /usr/ports/shells/zsh
>> > > (/usr/ports/infrastructure/mk/bsd.port.mk:2492 'test')
>> > >
>> > > after indicating that _all_ tests passed successfully. This bizarre
>> > > brekage has been around for a while now.
>> > >
>> > >
>> > > 2. The following simple patch fixes a compiler warning in
>> > > Src/Modules/langinfo.c
>> >
>> >
>> > Hi,
>> >
>> > below you find a diff with the compiler warning fix included. I'm ok
>> > with committing Pierre's original diff with or without this fix.
>> >
>>
>> Hi,
>>
>> Thanks for reminding me of this. Your patch works fine for me. I've
>> been running this patch for five months now with no issues worth
>> mentioning.
>>
>> I have no strong opinion about whether to include my minor patch or not.
>> I just reported the compiler warning upstream
>>
>> http://www.zsh.org/mla/workers/2015/msg00716.html
>>
>> so hopefully this will be fixed in the next zsh release anyway.
>>
>> Theo
>>
>
> Hi,
Hi,
> Is there any chance that this updated port will be committed soon or is
> there anything wrong with it? I'd really appreciate some news.
I guess pea and chrisz are both too busy. The update looks sane,
the new patch too, but I wonder why I get different regress tests
results.
===> Regression tests for zsh-5.0.7
cd Test ; make check
if test -n "cc"; then cd .. && DESTDIR= make MODDIR=`pwd`/Test/Modules
install.modules > /dev/null; fi
if ZTST_testlist="`for f in ./*.ztst; do echo $f; done`" ZTST_srcdir="."
ZTST_exe=../Src/zsh ../Src/zsh +Z -f ./runtests.zsh; then stat=0; else
stat=1; fi; sleep 1; rm -rf Modules .zcompdump; exit $stat
./A01grammar.ztst: starting.
This test hangs the shell when it fails...
./A01grammar.ztst: all tests successful.
./A02alias.ztst: starting.
This test hangs the shell when it fails...
./A02alias.ztst: all tests successful.
./A03quoting.ztst: starting.
./A03quoting.ztst: all tests successful.
./A04redirect.ztst: starting.
./A04redirect.ztst: all tests successful.
./A05execution.ztst: starting.
This test takes 5 seconds to fail...
./A05execution.ztst: all tests successful.
./A06assign.ztst: starting.
./A06assign.ztst: all tests successful.
./A07control.ztst: starting.
./A07control.ztst: all tests successful.
./B01cd.ztst: starting.
./B01cd.ztst: all tests successful.
./B02typeset.ztst: starting.
./B02typeset.ztst: all tests successful.
./B03print.ztst: starting.
./B03print.ztst: all tests successful.
./B04read.ztst: starting.
./B04read.ztst: all tests successful.
./B05eval.ztst: starting.
./B05eval.ztst: all tests successful.
./B06fc.ztst: starting.
./B06fc.ztst: all tests successful.
./B07emulate.ztst: starting.
./B07emulate.ztst: all tests successful.
./B08shift.ztst: starting.
./B08shift.ztst: all tests successful.
./C01arith.ztst: starting.
./C01arith.ztst: all tests successful.
./C02cond.ztst: starting.
This test takes two seconds...
./C02cond.ztst: all tests successful.
./C03traps.ztst: starting.
This test takes at least three seconds...
This test, too, takes at least three seconds...
Another test that takes three seconds
./C03traps.ztst: all tests successful.
./C04funcdef.ztst: starting.
./C04funcdef.ztst: all tests successful.
./C05debug.ztst: starting.
./C05debug.ztst: all tests successful.
./D01prompt.ztst: starting.
./D01prompt.ztst: all tests successful.
./D02glob.ztst: starting.
./D02glob.ztst: all tests successful.
./D03procsubst.ztst: starting.
./D03procsubst.ztst: all tests successful.
./D04parameter.ztst: starting.
./D04parameter.ztst: all tests successful.
./D05array.ztst: starting.
./D05array.ztst: all tests successful.
./D06subscript.ztst: starting.
./D06subscript.ztst: all tests successful.
./D07multibyte.ztst: starting.
Testing multibyte with locale en_US.UTF-8
./D07multibyte.ztst: all tests successful.
./D08cmdsubst.ztst: starting.
./D08cmdsubst.ztst: all tests successful.
./D09brace.ztst: starting.
./D09brace.ztst: all tests successful.
./E01options.ztst: starting.
This test hangs the shell when it fails...
./E01options.ztst: all tests successful.
./E02xtrace.ztst: starting.
./E02xtrace.ztst: all tests successful.
./V01zmodload.ztst: starting.
./V02zregexparse.ztst: starting.
./V02zregexparse.ztst: all tests successful.
./V03mathfunc.ztst: starting.
./V03mathfunc.ztst: all tests successful.
./V04features.ztst: starting.
./V04features.ztst: all tests successful.
./V05styles.ztst: starting.
./V05styles.ztst: all tests successful.
./V06parameter.ztst: starting.
./V06parameter.ztst: all tests successful.
./V07pcre.ztst: starting.
Testing PCRE multibyte with locale en_US.UTF-8
./V07pcre.ztst: all tests successful.
./V08zpty.ztst: starting.
Test ./V08zpty.ztst failed: bad status 1, expected 0 from:
zpty cat cat
zpty -w cat a line of text
var=
zpty -r cat var && print -r -- ${var%%$'\r\n'}
zpty -d cat
Error output:
(zpty):zpty:1: can't open pseudo terminal: bad file descriptor
(eval):zpty:2: no such pty command: cat
(eval):zpty:4: no such pty command: cat
(eval):zpty:5: no such pty command: cat
Was testing: zpty with a process that does not set up the terminal: internal
write
./V08zpty.ztst: test failed.
./X02zlevi.ztst: starting.
(zpty):zpty:21: can't open pseudo terminal: bad file descriptor
comptestinit:zpty:23: no such pty command: zsh
Test ./X02zlevi.ztst failed: non-zero status from preparation code:
if ( zmodload -i zsh/zpty ) >/dev/null 2>&1; then
. $ZTST_srcdir/comptest
comptestinit -v -z $ZTST_testdir/../Src/zsh
else
ZTST_unimplemented="the zsh/zpty module is not available"
fi
./X02zlevi.ztst: test failed.
Test ./X02zlevi.ztst failed: bad status 1, expected 0 from:
zletest $'word\euaend'
Error output:
zletest:zpty:3: no such pty command: zsh
zletest:zpty:4: no such pty command: zsh
Was testing: undo initial change
./X02zlevi.ztst: test failed.
./Y01completion.ztst: starting.
(zpty):zpty:21: can't open pseudo terminal: bad file descriptor
comptestinit:zpty:23: no such pty command: zsh
Test ./Y01completion.ztst failed: non-zero status from preparation code:
if ( zmodload -i zsh/zpty ) >/dev/null 2>&1; then
. $ZTST_srcdir/comptest
mkdir comp.tmp
cd comp.tmp
comptestinit -z $ZTST_testdir/../Src/zsh &&
{
mkdir dir1 &&
mkdir dir2 &&
touch file1 &&
touch file2
}
else
ZTST_unimplemented="the zsh/zpty module is not available"
fi
./Y01completion.ztst: test failed.
Test ./Y01completion.ztst failed: bad status 1, expected 0 from:
comptest $': \t\t\t\t\t\t\t'
Error output:
comptest:zpty:2: no such pty command: zsh
comptest:zpty:3: no such pty command: zsh
Was testing: directories and files
./Y01completion.ztst: test failed.
./Y02compmatch.ztst: starting.
(zpty):zpty:21: can't open pseudo terminal: bad file descriptor
comptestinit:zpty:23: no such pty command: zsh
Test ./Y02compmatch.ztst failed: non-zero status from preparation code:
if ( zmodload -i zsh/zpty ) >/dev/null 2>&1; then
. $ZTST_srcdir/comptest
mkdir match.tmp
cd match.tmp
comptestinit -z $ZTST_testdir/../Src/zsh &&
{
list1=(IndianRed IndianRed2 IndianRed3 IndianRed4)
test_code () {
matcher=$1;
list=$2;
code="compdef _tst tst ; _tst () { echo -n '<COMPADD>';compadd -M '"
code="$code$matcher"
code="$code' - ${(P)list} ; echo -n '</COMPADD>'"
code="$code; $extra_cmd"
code="$code; echo -n '<INSERT_POSITIONS>'"
code="$code; echo \$compstate[insert_positions]"
code="$code; echo -n '</INSERT_POSITIONS>'"
code="$code}"
comptesteval "$code"
}
}
else
ZTST_unimplemented="the zsh/zpty module is not available"
fi
./Y02compmatch.ztst: test failed.
Test ./Y02compmatch.ztst failed: bad status 1, expected 0 from:
test_code z: list1
comptest $'tst \t'
Error output:
(eval):1: command not found: test_code
comptest:zpty:2: no such pty command: zsh
comptest:zpty:3: no such pty command: zsh
Was testing: Match Error for "z:"
./Y02compmatch.ztst: test failed.
./Y03arguments.ztst: starting.
(zpty):zpty:21: can't open pseudo terminal: bad file descriptor
comptestinit:zpty:23: no such pty command: zsh
Test ./Y03arguments.ztst failed: non-zero status from preparation code:
if ( zmodload -i zsh/zpty ) >/dev/null 2>&1; then
. $ZTST_srcdir/comptest
mkdir comp.tmp
cd comp.tmp
comptestinit -z $ZTST_testdir/../Src/zsh &&
{
comptesteval 'compdef _tst tst'
tst_arguments () { comptesteval "_tst () { _arguments ${${(@qq)*}} }" }
}
else
ZTST_unimplemented="the zsh/zpty module is not available"
fi
./Y03arguments.ztst: test failed.
Test ./Y03arguments.ztst failed: bad status 1, expected 0 from:
tst_arguments ':desc1:(arg1)'
comptest $'tst \t\C-wa\t\C-war\t\C-warg\t\C-warg1\t\C-wr\t\C-wx\t \ty \t'
Error output:
(eval):1: command not found: tst_arguments
comptest:zpty:2: no such pty command: zsh
comptest:zpty:3: no such pty command: zsh
Was testing: one non-option argument
./Y03arguments.ztst: test failed.
**************************************
37 successful test scripts, 6 failures, 0 skipped
**************************************
*** Error 1 in Test (Makefile:204 'check')
*** Error 1 in /usr/ports/pobj/zsh-5.0.7/zsh-5.0.7 (Makefile:265 'check')
*** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2785
'/usr/ports/pobj/zsh-5.0.7/.test_done')
*** Error 1 in /usr/ports/shells/zsh
(/usr/ports/infrastructure/mk/bsd.port.mk:2476 'test')
ritchie /usr/ports/shells/zsh$
This is on -current, amd64. I also see 6 failures with zsh-5.0.5.
Ideas?
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
