On Fri, Mar 20, 2015, at 07:29 PM, Kent R. Spillner wrote:
> On Fri, Mar 20, 2015 at 08:00:12AM +0100, Dmitrij D. Czarkoff wrote:
> > Updated tarball. CATEGORY is set to "textproc devel" and sthen@'s mirror
> > is used as MASTER_SITES.
> 
> Tested on amd64; tests pass, everything looks fine (haven't tested the
> built-in web server, though).
> 
> ok kspillner@ fwiw.
> 

Tested on i386 snapshot from mar 19th.
 - all tests pass
 - the built-in webserver works correctly
 - the provided rc script works

One question about the default flags:
> daemon_flags="-http=:6060 -v=true"

Should it listen on all interfaces by default? I suggest setting it to
localhost
which makes it respond to both 'localhost:6060' & '127.0.0.1:6060' but
not
to any external interfaces that the system might have.

$ diff -uNp pkg/godoc.rc godoc.new                                       
--- pkg/godoc.rc        Fri Mar 20 07:34:39 2015
+++ godoc.new   Sat Mar 21 14:23:25 2015
@@ -3,7 +3,7 @@
 # $OpenBSD$
 
 daemon="${TRUEPREFIX}/bin/godoc"
-daemon_flags="-http=:6060 -v=true"
+daemon_flags="-http=localhost:6060 -v=true"
 daemon_user=www
 rc_bg=YES
 rc_reload=NO

Reply via email to