On 2014/11/22 22:58, Mxher wrote:
> Le 19/11/2014 22:08, Mxher a écrit :
> > Le 19/11/2014 00:16, Stuart Henderson a écrit :
> >> I've attached a port that's been sitting in mystuff for ages,
> >> there might be something you can borrow..
> >>
> >
> > Thanks.
> >
> > I see that you were doing two packages; I think that this is good idea.
> > I will change mine to do that too.
> >
> > I will take a closer look and post the results.
> >
>
> I have a first try to submit:
> http://c.mxher.fr/dibbler-1.0.0.tgz
>
> It's mostly the same package than the one I'm using for my own purpose,
> except two things I took from your package:
> - two dedicated packages for client and server,
> - post-install to change the examples directory.
>
>
> To build the package I had to set in the Makefile:
> CONFIGURE_ENV = CC=gcc CXX=g++
>
> Is there any better way to do that?
>
>
> Finally I still have few things to do:
> - create /var/lib/dibbler and /etc/dibbler, I think that I will use the
> @examples method explained on the FAQ
> (http://www.openbsd.org/faq/ports/specialtopics.html),
> - create rc.d files.
>
>
> Don't hesitate to tell me if I can improve or fix something.
>
>
> Mxher
- don't include REVISION (that is added if the port is changed after
committing)
- missing license marker should be "GPLv2 only" unless it changed since 0.8.4
- MAINTAINER should be Name <email>
- IMHO, DESCR should keep the Terry Pratchett reference ;-)
(DESCR doesn't need to talk about the license though).
- PLIST should be sorted, doc/ before examples/
- I don't see why you had to set CC/CXX, these are the very same programs
as the default cc/c++, and in any event they should not be hardcoded
$ ls -li /usr/bin/{cc,gcc,c++,g++}
132370 -r-xr-xr-x 2 root bin 201912 Nov 20 07:40 /usr/bin/c++
132372 -r-xr-xr-x 2 root bin 199704 Nov 20 07:40 /usr/bin/cc
132370 -r-xr-xr-x 2 root bin 201912 Nov 20 07:40 /usr/bin/g++
132372 -r-xr-xr-x 2 root bin 199704 Nov 20 07:40 /usr/bin/gcc
it builds ok without this line for me.
- in general we don't use /var/lib on OpenBSD. the files that dibbler
has in there seem to be a mixture of things we'd have in /var/db,
/var/run (pid files) and maybe others. I think that is probably about
the point I postponed work on this last time ;)
- USE_LIBTOOL=gnu is very much for special cases and should have a
comment explaining why it's used. or even better see if it can be fixed,
the old version didn't need this.
./ClntIfaceMgr/libClntIfaceMgr.a(libClntIfaceMgr_a-ClntIfaceMgr.o)(.text+0x348c):
In function `TClntIfaceMgr::select(unsigned int)':
: undefined reference to `TClntMsgReply::TClntMsgReply(int, SPtr<TIPv6Addr>,
char*, int)'
./ClntIfaceMgr/libClntIfaceMgr.a(libClntIfaceMgr_a-ClntIfaceMgr.o)(.text+0x35f3):
In function `TClntIfaceMgr::select(unsigned int)':
: undefined reference to `TClntMsgReconfigure::TClntMsgReconfigure(int,
SPtr<TIPv6Addr>, char*, int)'
collect2: ld returned 1 exit status
