On Mon, Oct 20, 2014 at 06:54:40PM +0100, Stuart Henderson wrote: > On 2014/10/20 19:42, David Coppa wrote: > > On Mon, Oct 20, 2014 at 5:57 PM, Antoine Jacoutot > > <[email protected]> wrote: > > > CVSROOT: /cvs > > > Module name: ports > > > Changes by: [email protected] 2014/10/20 09:57:12 > > > > > > Modified files: > > > x11/polkit-qt4 : Makefile > > > x11/polkit-qt4/pkg: PLIST > > > productivity/libqzeitgeist: Makefile > > > productivity/libqzeitgeist/pkg: PLIST > > > > > > Log message: > > > Pass -DCMAKE_BUILD_TYPE=Release to have a proper release.cmake file > > > instead > > > of the noconfig one. > > > > > > I wonder if at one point this should go into the cmake MODULE as a > > > default... > > > > Some days ago, I was going to mail ports@ suggesting exactly this. > > > > Would you give your ok?
Sure but some ports will fail to package because some filenames will change. > Would it make sense to only set this if no other -DCMAKE_BUILD_TYPE is set? > (Otherwise it would be more awkward to do a -DCMAKE_BUILD_TYPE=Debug build for > a single port). Of course :-) -- Antoine
