On 2014/09/09 23:26, Dmitrij D. Czarkoff wrote: > Stuart Henderson said: > > - zap the empty REVISION line > > Done. > > > - set the date used for DISTNAME/PKGNAME versioning to that of the last > > code change (20130317), though I tend to prefix it i.e. 0.20130317 to > > avoid ugly non-removable EPOCH markers if a proper release is made > > Done. > > > - add an @conflict marker for the conflict with security/pgp5 (or > > install the lib to a subdir to avoid the conflict) > > Added @conflict. (This package only makes sense as build dependency, so > conflict is not a big deal here I guess.) Maybe I should make a separate > port for bnlib and make this port, as well as security/pgp5, depend on > it?
seems like it's probably overkill at the moment, though if these started providing shared libraries that might be a good idea. > > - add a comment explaining why it needs gnu libtool (if it is only needed > > for the m4 macros, don't set USE_LIBTOOL at all, just add devel/libtool > > as a build dep). > > USE_LIBTOOL dropped. > > Updated port attached. Here's a version with a few more tweaks; - regen distinfo for the 0.xx PKGNAME change - add "telephony" to categories so it can be imported there; that category seems relevant to this port and isn't as busy as security/ - patch configure.in to avoid forced optimizer / debug CFLAGS I do get a failure with 'make test', do you see that too? (not a show-stopper, but if it's easy to fix then maybe worth it). <snip> make cache_test if cc -DHAVE_CONFIG_H -I. -I. -I./config -I./include -I./. -I./test -I./test/cmockery -I./third_party/bgaes -I./third_party/bnlib -O2 -pipe -std=c99 -O2 -g3 -Wall -Wextra -Wno-unused-parameter -fno-strict-aliasing -fPIC -DZRTP_AUTOMAKE=1 -MT cache_test-cache_test.o -MD -MP -MF ".deps/cache_test-cache_test.Tpo" -c -o cache_test-cache_test.o `test -f './test/cache_test.c' || echo './'`./test/cache_test.c; then mv -f ".deps/cache_test-cache_test.Tpo" ".deps/cache_test-cache_test.Po"; else rm -f ".deps/cache_test-cache_test.Tpo"; exit 1; fi ./test/cache_test.c: In function 'cache_setup_file': ./test/cache_test.c:129: warning: implicit declaration of function 'zrtp_cache_db_create' ./test/cache_test.c:129: error: 'g_db_config' undeclared (first use in this function) ./test/cache_test.c:129: error: (Each undeclared identifier is reported only once ./test/cache_test.c:129: error: for each function it appears in.) ./test/cache_test.c:129: error: 'zrtp_cache_db_t' undeclared (first use in this function) ./test/cache_test.c:129: error: expected expression before ')' token ./test/cache_test.c:141: warning: implicit declaration of function 'zrtp_cache_db_destroy' ./test/cache_test.c:149: error: expected expression before ')' token ./test/cache_test.c: In function 'cache_save_unchanged_test': ./test/cache_test.c:243: error: 'g_db_config' undeclared (first use in this function) ./test/cache_test.c:243: error: 'zrtp_cache_db_t' undeclared (first use in this function) ./test/cache_test.c:243: error: expected expression before ')' token ./test/cache_test.c: In function 'cache_modify_and_save_test': ./test/cache_test.c:310: error: 'g_db_config' undeclared (first use in this function) ./test/cache_test.c:310: error: 'zrtp_cache_db_t' undeclared (first use in this function) ./test/cache_test.c:310: error: expected expression before ')' token ./test/cache_test.c: In function 'cache_name_test': ./test/cache_test.c:367: error: 'g_db_config' undeclared (first use in this function) ./test/cache_test.c:367: error: 'zrtp_cache_db_t' undeclared (first use in this function) ./test/cache_test.c:367: error: expected expression before ')' token *** Error 1 in . (Makefile:1141 'cache_test-cache_test.o') *** Error 1 in . (Makefile:1446 'check-am') *** Error 1 in /usr/obj/ports/libzrtp-0.20130317/libzrtp-4cb5110147d2bb7e0466eec8ec838d8372ef54c9 (Makefile:1200 'check-recursive')
libzrtp.tgz
Description: application/tar-gz
