Hi Andrew, On Mon, Apr 07, 2014 at 09:45:33PM -0700, Andrew Fresh wrote: > I am not too sure how to port a node package, this confused me quite a > bit, but it seems to work. > > Feedback is much appreciated.
Seems to work. A few comments: * License is just 3 clause BSD, no? * Strictly speaking, either security/gnupg or security/gnupg2 are a suitable RUN_DEPEND, although I am not aware of a way of encoding that in a port. (I use gnupg2 so I can use gpg-agent). * It's kind of annoying that it packages 30 dependent node packages statically. I guess in an ideal world, we would make a port for these and use system versions. (or would we?). * Probably want to disable 'keybase update' as it clearly won't work. Food for thought. -- Best Regards Edd Barrett http://www.theunixzoo.co.uk
