On 2013/11/28 16:43, Stuart Henderson wrote: > On 2013/11/28 20:14, Vadim Zhukov wrote: > > > > What .todo? ;) > > > > Two nits: > > > > 1) "network" probably will be more appropriate than "www" in > > CATEGORIES, no? > > net/ is fairly huge, I'd rather not add more things there unless > it really makes sense .. though actually www/ is fairly huge too. > So maybe it's better to just list it in security. > > > 2) 3 tests fail on i386 (see below), is this known and okay? If not, I > > could take a look into them. > > Thanks - I have a clean test run on i386, amd64, macppc, but I have now > managed to repeat this with J in malloc flags, I'll see if I can figure > out what's up. My runtime tests are still successful with J. >
Actually... 97%: Checks: 112, Failures: 3, Errors: 0 cert.t.c:66:F:cert_refcount_inc:cert_refcount_inc_01:0: refcount mismatch cachefkcrt.t.c:116:F:cache_fkcrt:cache_fkcrt_04:0: refcount != 0 cachetgcrt.t.c:114:F:cache_tgcrt:cache_tgcrt_04:0: refcount != 0 GNUmakefile:280: recipe for target 'test' failed cert.t.c has this: 63 fail_unless(c->references == 1, "refcount mismatch"); 64 cert_free(c); 65 /* deliberate access after last free() */ 66 fail_unless(c->references == 0, "refcount mismatch"); 67 } 68 END_TEST So this is working as expected. I'll add a comment to Makefile and commit it.
