On 2013/11/25 20:31, Christopher Zimmermann wrote:
> On Sun, 24 Nov 2013 23:34:31 +0100 Christopher Zimmermann
> <[email protected]> wrote:
>
> > Hi,
> >
> > below you find a new port of a board game GUI for Go, Amazons and
> > Reversi. OK?
> >
> > Christopher
>
> Thanks for the improvement suggestions to Landry and Antoine!
> I have included them in the following diff.
> The very long html diff is from upstreams merge queue and fixes the
> fake stage.
> OK?
could you please use the new DISTFILES syntax to trigger a rename,
to avoid a junk dir in distfiles/?
--- Makefile- Tue Nov 26 19:37:40 2013
+++ Makefile Tue Nov 26 19:37:41 2013
@@ -8,8 +8,7 @@ V = 0.3.0.1
DISTNAME = quarry-${V}
MASTER_SITES = https://gitorious.org/quarry/quarry/archive/
-DIST_SUBDIR = quarry
-DISTFILES = ${V}.tar.gz
+DISTFILES = ${DISTNAME}${EXTRACT_SUFX}{${V}${EXTRACT_SUFX}}
WRKDIST = ${WRKDIR}/quarry-quarry
HOMEPAGE = https://gitorious.org/quarry/pages/Home
--- distinfo- Tue Nov 26 19:38:32 2013
+++ distinfo Tue Nov 26 19:37:49 2013
@@ -1,2 +1,2 @@
-SHA256 (quarry/0.3.0.1.tar.gz) = f6T62WLgXW5UyMCEYqrWuUQQUXgNEUCAReA9vm6gFNc=
-SIZE (quarry/0.3.0.1.tar.gz) = 1474758
+SHA256 (quarry-0.3.0.1.tar.gz) = f6T62WLgXW5UyMCEYqrWuUQQUXgNEUCAReA9vm6gFNc=
+SIZE (quarry-0.3.0.1.tar.gz) = 1474758
also:
$ /usr/ports/infrastructure/bin/portcheck
1 line(s) longer than 80 chars in Makefile
missing RDEP on devel/desktop-file-utils
missing @exec of update-desktop-database
missing @unexec-delete of update-desktop-database
missing RDEP on misc/shared-mime-info
missing @exec of update-mime-database
missing @unexec-delete of update-mime-database
games/quarry
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ Makefile 25 Nov 2013 19:25:04 -0000
btw, while diffs are preferred for changes to existing ports,
sending a new port as a diff is quite awkward for recipients to
handle, attached tgz are much easier.
