Gleydson Soares <[email protected]> writes:
> [email protected] writes:
>
>> Hi ports --
>>
>> Attached is a port of cgo, a terminal-based gopher client.
>> Works well for me on amd64, loongson, and macppc.
>>
>> OK?
>>
>> ~Brian
>
> #1
> this line seems long:
> perl -pi -e
> "s,firefox,${LOCALBASE}/bin/firefox,g|s,display,${LOCALBASE}/bin/display,g|s,mplayer,${LOCALBASE}/bin/mplayer,g"
> ${WRKSRC}/cgo.c
Using absolute paths takes one configuration trick away from the user.
(eg. $ cat ~/bin/mplayer
#! /bin/sh
exec /usr/local/bin/myplayer
)
And for this package, it's the only trick available. I'd say it does
more harm than good here.
> reads better:
> perl -pi -e "s,firefox,${LOCALBASE}/bin/firefox,g|s,display, \
>
> ${LOCALBASE}/bin/display,g|s,mplayer,${LOCALBASE}/bin/mplayer,g"
> ${WRKSRC}/cgo.c
Or even separate s,,, lines:
perl -pi \
-e "s,display,${LOCALBASE}/bin/display,g;" \
-e "s,firefox,${LOCALBASE}/bin/firefox,g;" \
-e "s,mplayer,${LOCALBASE}/bin/mplayer,g;" \
${WRKSRC}/cgo.c
> #2
> `make regress' failed, the port does not have regression tests so requires
> NO_TEST.
>
> ===> Regression tests for cgo-20130722
> make: don't know how to make test
> Stop in /usr/ports/pobj/cgo-20130722/cgo-20130722
>
> with changes, OK gsoares@
I can't test it right now so no opinion.
--
jca | PGP : 0x06A11494 / 61DB D9A0 00A4 67CF 2A90 8961 6191 8FBF 06A1 1494
