netbeans updates are huge, i think it's better to gzip them or post them on the web instead of just sending them in-line.
I've put some comments in-line below. but most importantly, the JDK for 1.6 has changed from oracle/sun to openjdk. How much testing did you do? I think it's important to do some real stress testing of netbeans using openjdk at this point. My main concern is that we'll have to move from pre-compiled java binaries to having to do a source build. doing a source build might be good to do anyway to get the profiler working on openbsd and the other native code modules. do you feel like taking a look into that? the downside is that it will increase the package build time significantly. Another issue is that netbeans 6.9.1 is the last version with Ruby support. I don't know if anyone is using that combination but it could be an issue for some people. What are your thoughts? Take a look here: http://wiki.netbeans.org/RubySupport > MODJAVA_VER can stay at 1.6+ or 1.7+? Initially the rationale was to have the > GPL licensed 1.7, now that both 1.6 and 1.7 are permissible to distribute, > either is fine. definitely keep at 1.6+ unless there's a requirement for netbeans to use 1.7. > > feedback welcome. tested on amd64. > > > Index: Makefile > =================================================================== > RCS file: /cvs/ports/devel/netbeans/Makefile,v > retrieving revision 1.23 > diff -u -p -r1.23 Makefile > --- Makefile 2 Dec 2011 08:29:45 -0000 1.23 > +++ Makefile 8 Mar 2013 19:20:02 -0000 > @@ -4,27 +4,28 @@ SHARED_ONLY= Yes > > COMMENT= NetBeans Java IDE > > -V= 6.9.1 > -DISTNAME= netbeans-${V} > +V= 7.3 > +DISTNAME= netbeans-${V}-201302132200 > +PKGNAME= netbeans-${V} why reintroduce PKGNAME? the current way works fine. Take a look through ports, the idiom of using EXTRACT_SUFX like this is used in a few places. > CATEGORIES= devel > -REVISION= 4 > > HOMEPAGE= http://www.netbeans.org/ > > +MAINTAINER= Rafael Sadowski <raf...@sizeofvoid.org> > + > # CDDL and GPLv2 dual-licensed > # > # For external components see: > # http://www.netbeans.info/downloads/licence/netbeans-3rd-party.txt > PERMIT_PACKAGE_CDROM= Yes > PERMIT_PACKAGE_FTP= Yes > -PERMIT_DISTFILES_CDROM= Yes > PERMIT_DISTFILES_FTP= Yes > > -MASTER_SITES= http://download.netbeans.org/netbeans/${V}/final/zip/ > -EXTRACT_SUFX= -201007282301-ml.zip > +MASTER_SITES= > http://dlc.sun.com.edgesuite.net/netbeans/${V}/final/zip/ why change the MASTER_SITES link? > +EXTRACT_SUFX= .zip > > MODULES= java > -MODJAVA_VER= 1.6+ > +MODJAVA_VER= 1.7+ Please keep it on 1.6+ unless 1.7 is required and read the paragraph at the bottom from kurt: http://marc.info/?l=openbsd-ports&m=136261941413852&w=2 > > RUN_DEPENDS= java/javaPathHelper \ > devel/desktop-file-utils > @@ -35,9 +36,6 @@ NO_REGRESS= Yes > WRKDIST= ${WRKDIR}/netbeans > > NB= ${PREFIX}/netbeans > - > -pre-configure: > - @${SUBST_CMD} ${WRKSRC}/platform/lib/nbexec i didn't look too closely at this change, but why is it needed? > > do-install: > ${INSTALL_DATA_DIR} ${NB} > Index: distinfo > =================================================================== > RCS file: /cvs/ports/devel/netbeans/distinfo,v > retrieving revision 1.5 > diff -u -p -r1.5 distinfo > --- distinfo 12 Nov 2010 12:26:16 -0000 1.5 > +++ distinfo 8 Mar 2013 19:20:02 -0000 > @@ -1,5 +1,2 @@ > -MD5 (netbeans-6.9.1-201007282301-ml.zip) = wxBgq8bTPPgrF+JVwQD+QA== > -RMD160 (netbeans-6.9.1-201007282301-ml.zip) = PR7GEJf7Dqlp5GoH+Tb9iob9Yww= > -SHA1 (netbeans-6.9.1-201007282301-ml.zip) = Az8R2KLpFXB9IkZXtqZ4cIDgJsw= > -SHA256 (netbeans-6.9.1-201007282301-ml.zip) = > NxfYxhyDqgyExDQxtrN8VvJzmd2JZRqn4CRYDOlqZow= > -SIZE (netbeans-6.9.1-201007282301-ml.zip) = 261676411 > +SHA256 (netbeans-7.3-201302132200.zip) = > DB+7MYCG7LHNqDk/j1AeiHpGrxxJJ3Y1Ph4WK/0/BVk= > +SIZE (netbeans-7.3-201302132200.zip) = 281722325 > Index: patches/patch-etc_netbeans_conf > =================================================================== > RCS file: /cvs/ports/devel/netbeans/patches/patch-etc_netbeans_conf,v > retrieving revision 1.3 > diff -u -p -r1.3 patch-etc_netbeans_conf > --- patches/patch-etc_netbeans_conf 12 Nov 2010 12:26:16 -0000 1.3 > +++ patches/patch-etc_netbeans_conf 8 Mar 2013 19:20:02 -0000 > @@ -1,16 +1,12 @@ > -$OpenBSD: patch-etc_netbeans_conf,v 1.3 2010/11/12 12:26:16 jasper Exp $ > - > -Turn autoupdate off by default. The relevant options are documented here: > - http://wiki.netbeans.org/FaqPluginManagerCustomization > - why are you removing this comment? in my opinion we don't have enough comments explaining the rationale for patches in ports. it's a real time sink to update a port when you come across a patch and have to spend time figuring things out without any context. please keep this in. > ---- etc/netbeans.conf.orig Thu Jul 29 02:06:10 2010 > -+++ etc/netbeans.conf Tue Nov 9 21:48:58 2010 > -@@ -3,7 +3,7 @@ netbeans_default_userdir="${HOME}/.netbeans/6.9" > +$OpenBSD$ > +--- etc/netbeans.conf.orig Wed Feb 27 11:58:52 2013 > ++++ etc/netbeans.conf Wed Feb 27 12:02:08 2013 > +@@ -43,7 +43,7 @@ netbeans_default_cachedir="${DEFAULT_CACHEDIR_ROOT}/7. > + # Concurrent Mark & Sweep garbage collector. > + # (see http://wiki.netbeans.org/FaqGCPauses) > + # > +-netbeans_default_options="-J-client -J-Xss2m -J-Xms32m -J-XX:PermSize=32m > -J-Dapple.laf.useScreenMenuBar=true -J-Dapple.awt.graphics.UseQuartz=true > -J-Dsun.java2d.noddraw=true -J-Dsun.java2d.dpiaware=true > -J-Dsun.zip.disableMemoryMapping=true -J-Dsun.awt.disableMixing=true" > ++netbeans_default_options="-J-client -J-Xss2m -J-Xms32m -J-XX:PermSize=32m > -J-XX:MaxPermSize=200m -J-Dapple.laf.useScreenMenuBar=true > -J-Dapple.awt.graphics.UseQuartz=true -J-Dsun.java2d.noddraw=true > -J-Dsun.java2d.dpiaware=true -J-Dsun.awt.disableMixing=true > -J-Dplugin.manager.check.updates=false > -J-Dplugin.manager.check.interval=NEVER" > > - # Options used by NetBeans launcher by default, can be overridden by > explicit > - # command line switches: > --netbeans_default_options="-J-client -J-Xss2m -J-Xms32m -J-XX:PermSize=32m > -J-XX:MaxPermSize=200m -J-Dapple.laf.useScreenMenuBar=true > -J-Dapple.awt.graphics.UseQuartz=true -J-Dsun.java2d.noddraw=true" > -+netbeans_default_options="-J-client -J-Xss2m -J-Xms32m -J-XX:PermSize=32m > -J-XX:MaxPermSize=200m -J-Dapple.laf.useScreenMenuBar=true > -J-Dapple.awt.graphics.UseQuartz=true -J-Dsun.java2d.noddraw=true > -J-Dplugin.manager.check.updates=false > -J-Dplugin.manager.check.interval=NEVER" > - # Note that a default -Xmx is selected for you automatically. > - # You can find this value in var/log/messages.log file in your userdir. > - # The automatically selected value can be overridden by specifying -J-Xmx > here > + # Default location of JDK: > + # (set by installer or commented out if launcher should decide) > Index: patches/patch-platform_lib_nbexec > =================================================================== > RCS file: /cvs/ports/devel/netbeans/patches/patch-platform_lib_nbexec,v > retrieving revision 1.1 > diff -u -p -r1.1 patch-platform_lib_nbexec > --- patches/patch-platform_lib_nbexec 9 Jul 2010 07:35:04 -0000 1.1 > +++ patches/patch-platform_lib_nbexec 8 Mar 2013 19:20:02 -0000 > @@ -1,7 +1,7 @@ > -$OpenBSD: patch-platform_lib_nbexec,v 1.1 2010/07/09 07:35:04 landry Exp $ > ---- platform/lib/nbexec.orig Thu Jun 10 19:59:48 2010 > -+++ platform/lib/nbexec Sun Jun 20 02:16:30 2010 > -@@ -357,7 +357,7 @@ detect_system_proxy () { > +$OpenBSD$ > +--- platform/lib/nbexec.orig Tue Feb 26 17:17:07 2013 > ++++ platform/lib/nbexec Tue Feb 26 17:21:26 2013 > +@@ -364,7 +364,7 @@ detect_system_proxy () { > } > > detect_gnome_proxy () { > @@ -10,7 +10,7 @@ $OpenBSD: patch-platform_lib_nbexec,v 1. > if [ -x $gconftool ] ; then > proxy_mode=`$gconftool --get /system/proxy/mode 2>/dev/null` > if [ "$proxy_mode" = "manual" ] ; then > -@@ -366,7 +366,7 @@ detect_gnome_proxy () { > +@@ -373,7 +373,7 @@ detect_gnome_proxy () { > http_proxy_tmp=$http_proxy_host:$http_proxy_port > http_non_proxy_hosts=`$gconftool --get > /system/http_proxy/ignore_hosts 2>/dev/null` > if [ $? ] ; then > @@ -19,7 +19,7 @@ $OpenBSD: patch-platform_lib_nbexec,v 1. > fi > socks_proxy_host=`$gconftool --get /system/proxy/socks_host > 2>/dev/null` > socks_proxy_port=`$gconftool --get /system/proxy/socks_port > 2>/dev/null` > -@@ -389,18 +389,18 @@ detect_gnome_proxy () { > +@@ -405,18 +405,18 @@ detect_gnome_proxy () { > detect_kde_proxy () { > kioslaverc="${HOME}/.kde/share/config/kioslaverc" > if [ -f $kioslaverc ] ; then > Index: pkg/PLIST > =================================================================== > RCS file: /cvs/ports/devel/netbeans/pkg/PLIST,v > retrieving revision 1.6 > diff -u -p -r1.6 PLIST > --- pkg/PLIST 11 May 2011 06:22:17 -0000 1.6 > +++ pkg/PLIST 8 Mar 2013 19:20:03 -0000 > @@ -1,10 +1,7 @@ > @comment $OpenBSD: PLIST,v 1.6 2011/05/11 06:22:17 ajacoutot Exp $ > -@unexec rm -rf %D/netbeans/nb/servicetag i'm not sure this is right. > bin/netbeans > netbeans/ > netbeans/CREDITS.html > -netbeans/DISTRIBUTION.txt > -netbeans/LEGALNOTICE.txt > netbeans/LICENSE.txt > netbeans/README.html > netbeans/THIRDPARTYLICENSE.txt other than that. - pkg/README needs to be updated to not refer to firefox 3.5. I would take out the version number and make it more generic. - pkg/DESCR is out of date. I believe JavaFX and Ruby mentions need to be removed at this point. some possible patches for these items: Index: pkg/DESCR =================================================================== RCS file: /home/cvs/ports/devel/netbeans/pkg/DESCR,v retrieving revision 1.3 diff -u -r1.3 DESCR --- pkg/DESCR 3 Apr 2010 11:42:06 -0000 1.3 +++ pkg/DESCR 8 Feb 2013 04:30:38 -0000 @@ -1,6 +1,5 @@ The NetBeans IDE is a multi-platform, integrated development environment consisting of an open-source IDE and an application -platform that enable developers to create web, enterprise, desktop, -and mobile applications using the Java platform, as well as JavaFX, -PHP, JavaScript and Ajax, Ruby and Ruby on Rails, Groovy and Grails, -and C/C++. +platform that enables developers to create web, enterprise, desktop, +and mobile applications using the Java platform, as well as PHP, +JavaScript and Ajax, Groovy and Grails, and C/C++. Index: pkg/README =================================================================== RCS file: /home/cvs/ports/devel/netbeans/pkg/README,v retrieving revision 1.2 diff -u -r1.2 README --- pkg/README 2 Jun 2011 13:41:38 -0000 1.2 +++ pkg/README 8 Feb 2013 04:30:39 -0000 @@ -11,12 +11,14 @@ the online help system. Firefox is not set up as a runtime dependency as this dependency is optional. -If you have Firefox 3.5 on your system you may want to set up the -following symbolic link: +If you have some version of Firefox on your system you may want to set +up a symbolic link: -ln -s ${LOCALBASE}/bin/firefox35 ${LOCALBASE}/bin/firefox +ln -s ${LOCALBASE}/bin/firefox<VER> ${LOCALBASE}/bin/firefox + +Alternatively, you can also customize this setting within the IDE by +going to: -You can also customize this setting within the IDE by going to Tools> Options> General> Web Browser. Font issues in the output window
