On Thu, Aug 23, 2012 at 12:48:07AM -0400, Brad Smith wrote: > On Thu, Aug 23, 2012 at 11:47:27AM +1000, Jonathan Gray wrote: > > sdl-config --cflags unconditionally sets _GNU_SOURCE, > > as non posix glibc functions are often hidden under this > > ifdef it tends to break code and I see no reason to define it. > > This looks good and SDL 2 removes the use of this flag. After asking about the use of _GNU_SOURCE upstream it has been removed even for the SDL 1.2 branch..
> Could some Linux users try building with this and see if there are
>
>
> any issues?
Generates the exact same SDL_config.h on this Ubuntu 11.10 system,
builds without any compiler warnings.
It _does_, however, build a library with a different md5 signature. I
don't know if that's important at all, but it definitely changes
_something_.
--ryan.
> OK how about to be on the safe and conservative side we keep _GNU_SOURCE
>
>
> for GLIBC using hosts and remove it for the rest.
>
>
Screw it, I just removed it outright. We'll see if anyone complains.
--ryan.
http://hg.libsdl.org/SDL/rev/7b87c1773b3e
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
