On 2012/05/27 22:34, wen heping wrote:
> 2012/5/27 Antoine Jacoutot <[email protected]>
>
> > On Sun, May 27, 2012 at 09:35:13PM +0800, wen heping wrote:
> > > I found no ports depends on pecl-zip in portstree. But I suggest add
> >
> > There are at least photoshow and owncloud that depend on it.
> >
>
> You are right.
> And now I am sure only photoshow and owncloud that depend on it :)
> Thanks!
>
> I attached revised patch.
>
> wen
Nearly done, but there are still a couple of issues:
> Index: archivers/pecl-zip/Makefile
This needs unhooking from archivers/Makefile too
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ lang/php/5.2/pkg/PLIST-zip 27 May 2012 12:53:48 -0000
> @@ -0,0 +1,7 @@
> +@comment $OpenBSD$
> +@option no-default-conflict
> +@conflict php-zip->=5.2,<5.3
> +@pkgpath www/php5/extensions,-zip
@pkgpath should be on archivers/pecl-zip, and it requires an
@conflict marker on pecl-zip as well as the one you've already added.
> +++ lang/php/5.3/pkg/PLIST-zip 27 May 2012 12:53:48 -0000
> @@ -0,0 +1,6 @@
> +@comment $OpenBSD$
> +@option no-default-conflict
> +@conflict php-zip->=5.3,<5.4
> +lib/php-${PV}/modules/zip.so
> +share/examples/php-${PV}/zip.ini
> +@sample ${SYSCONFDIR}/php-${PV}.sample/zip.ini
Missing @pkgpath, and it requires an @conflict marker on
pecl-zip as well as the one you've already added.
> --- www/owncloud/Makefile 3 May 2012 07:20:42 -0000 1.5
> +++ www/owncloud/Makefile 27 May 2012 14:28:26 -0000
> @@ -38,7 +38,7 @@
> TINSTDIR= ${TRUEPREFIX}/owncloud
> SUBST_VARS= INSTDIR TINSTDIR
>
> -RUN_DEPENDS= archivers/pecl-zip \
> +RUN_DEPENDS= lang/php/${MODPHP_VERSION},-zip \
> lang/php/${MODPHP_VERSION},-curl \
> lang/php/${MODPHP_VERSION},-gd
Missing REVISION bump
> Index: www/photoshow/Makefile
> ===================================================================
> RCS file: /cvs/ports/www/photoshow/Makefile,v
> retrieving revision 1.3
> diff -u -r1.3 Makefile
> --- www/photoshow/Makefile 15 Mar 2012 13:38:33 -0000 1.3
> +++ www/photoshow/Makefile 27 May 2012 14:30:42 -0000
> @@ -27,7 +27,7 @@
> TINSTDIR= ${TRUEPREFIX}/photoshow
> SUBST_VARS= INSTDIR TINSTDIR
>
> -RUN_DEPENDS= archivers/pecl-zip
> +RUN_DEPENDS= lang/php/${MODPHP_VERSION},-zip
>
> do-install:
> cp -R ${WRKSRC} ${INSTDIR}
Also missing REVISION bump
