On Mon, Feb 20, 2012 at 11:11:51PM +1100, Jonathan Gray wrote: > What is the reason for limiting mplayer to the set of archs it has? > > ONLY_FOR_ARCHS = alpha amd64 arm i386 mips64 mips64el powerpc sparc64 > > it compiles and runs on hppa so if nothing else hppa should be added, > but should the list go entirely? As it stands the list is very > close to GCC4_ARCHS.
In any case, IMHO if some arches don't support it, better set NOT_FOR_ARCHS instead of bloating ONLY_FOR_ARCHS. > Index: Makefile > =================================================================== > RCS file: /cvs/ports/x11/mplayer/Makefile,v > retrieving revision 1.198 > diff -u -p -r1.198 Makefile > --- Makefile 26 Jan 2012 20:21:31 -0000 1.198 > +++ Makefile 20 Feb 2012 12:04:07 -0000 > @@ -1,7 +1,7 @@ > # $OpenBSD: Makefile,v 1.198 2012/01/26 20:21:31 ratchov Exp $ > > # May not be hard to add more. > -ONLY_FOR_ARCHS = alpha amd64 arm i386 mips64 mips64el powerpc sparc64 > +ONLY_FOR_ARCHS = alpha amd64 arm hppa i386 mips64 mips64el powerpc > sparc64 > > COMMENT = movie player supporting many formats > > -- Antoine
