On 2012/02/12 19:47, Gabriel Guzman wrote:
> Problem: Darktable doesn't run after pkg_add unless you install lensfun first.
> 
> Duplicate the problem (on a clean system):
> $ sudo pkg_add darktable
> $ darktable
> darktable: can't load library 'liblensfun.so'
> 
> fix: 
> 
> $ sudo pkg_add lensfun
> $ darktable
> works.
> 
> Looking at the /usr/ports/graphics/darktable/Makefile  
> 
> I see "graphics/lensfun" in LIB_DEPENDS, but maybe it needs to be added to 
> RUN_D
> EPENDS as well?  

Thanks for the report.

RUN_DEPENDS seems wrong. It looks like LIB_DEPENDS is silently stripped
if no WANTLIB coming from that package is found. (It would be nice if
pkg_create, or at least check-lib-depends, warned about this).

I think this is a better diff:

Index: Makefile
===================================================================
RCS file: /cvs/ports/graphics/darktable/Makefile,v
retrieving revision 1.17
diff -u -p -r1.17 Makefile
--- Makefile    22 Dec 2011 15:20:10 -0000      1.17
+++ Makefile    13 Feb 2012 09:51:19 -0000
@@ -5,6 +5,7 @@ ONLY_FOR_ARCHS= i386 amd64
 
 COMMENT=       virtual lighttable and darkroom for photographers
 DISTNAME=      darktable-0.9.3
+REVISION=      0
 
 SHARED_ONLY=   Yes
 
@@ -26,6 +27,7 @@ WANTLIB += gdk_pixbuf-2.0 gio-2.0 glib-2
 WANTLIB += gobject-2.0 gphoto2 gthread-2.0 gtk-x11-2.0 jpeg lcms2
 WANTLIB += m pango-1.0 pangocairo-1.0 png pthread rsvg-2 sqlite3
 WANTLIB += stdc++ tiff xml2 z
+WANTLIB += lensfun # dlopen()d; shows as Extra but still needed
 
 MASTER_SITES=  ${MASTER_SITE_SOURCEFORGE:=darktable/}
 

Reply via email to