On Wed, Jan 18, 2012 at 11:52:52PM +0000, Stuart Henderson wrote:
> On 2012/01/18 22:09, Marcus Glocker wrote:
> > On Wed, Jan 18, 2012 at 03:44:07PM -0500, Jiri B wrote:
> >
> > > On Wed, Jan 18, 2012 at 08:02:45PM +0100, Marcus Glocker wrote:
> > > > Hey,
> > > >
> > > > Attached a new port.
> > > >
> > > > DESCR:
> > > > NeDi is a powerful network discovery tool with a comfortable web
> > > > interface.
> > >
> > > Last release 2007? Seems dead. netdisco is not OK?
>
> Do you know of any port submission for netdisco?
>
> > NeDi 1.0.7 has been released on 04.12.2011. Also I know the developer
> > in person and he already works on new stuff for future releases.
>
> Can you ask him to fix the line-endings and kill the short_open_tags
> requirement please? :-)
>
> Diff inline (done as a git diff to make it easier for me, apply with
> patch -p1 -E), and a replacement tgz (including .git) attached.
> A few comments on what I've changed (not listing everything here; read it
> in conjunction with the diff)
>
> I've logged into the web interface and browsed around but have not set
> anything up yet nor run any of the perl scripts so there might still be
> more to do.
>
> - install into /var/www/nedi. it may very well be a complete pain to run
> totally chrooted, but at least this gives adventurous people a chance
> to install the right files inside chroot to have a chance of getting
> things working, without having to move everything installed by the port..
>
> - several files which will obviously change are installed under .dist
> names and @sample'd into place, so that future upgrades won't conflict
> and/or lose the local changes. there may be more of these to do.
>
> - the usual php scripts etc. should be protected against writing by
> the webserver, so most files are now installed as root/daemon. some files
> and directories do need to be writable; I've added @group/@mode for the
> obvious ones, but again there may be more of these to do
>
> - 'make plist' has substituted "5.3" in filenames with "${MODPHP_VERSION}",
> I've fixed these, they'll need fixing again if you rerun 'make plist'.
>
> - moved MESSAGE to README, tell people to restart httpd with /etc/rc.d/httpd
> (some of us need login.conf LD_PRELOAD lines for pthread which require the
> correct login class to be used, rc.d handles this)
>
> - tell people to only symlink the html dir into /var/www/htdocs, not the
> whole nedi directory. config files etc shouldn't be directly fetchable by
> http and it's a lot safer to do it that way than with .htaccess.
Hmm. nedi.pl is broken now. E.g. when running a network discovery:
DBD::mysql::st execute failed: Unknown column 'viewdev' in 'field list' at
/var/www/nedi/inc/libdb-msq.pm line 1398.
DBD::mysql::st execute failed: Unknown column 'viewdev' in 'field list' at
/var/www/nedi/inc/libdb-msq.pm line 1398.
