On Sun, Jul 10, 2011 at 12:00:28AM +0000, Jona Joachim wrote: > On 2011-06-30, Jona Joachim <[email protected]> wrote: > > On 2011-06-29, Landry Breuil <[email protected]> wrote: > >> On Wed, Jun 29, 2011 at 09:43:52PM +0200, Jona Joachim wrote: > >>> Hi, > >>> > >>> ManaPlus is an extended client for The Mana World and similar > >>> eAthena-based MMORPG game servers. > >>> > >>> > >>> We have the official TMW client under games/tmw. Most regular players > >>> use ManaPlus. > >>> > >>> Tested on amd64 and i386. > >> > >> It's usually simpler to patch Makefile.in files and avoid rerunning > >> autohell. PLIST lacks the @exec/@unexec lines for the desktop file. > >> The LIB_DEPENDS line looks huge, arent there some things dragged by > >> another dependency which would only belong to WANTLIB ? > > > > I agree on the Makefile.in part, however upstream only provides .am files.
That'd be nice if upstream provided them too, so that you only need to run configure like every regular port using autohell :) > > I added @exec/@unexec, and removed unnecessary stuff from LIB_DEPENDS. > > > > You can find the updated port here: > > http://www.hcl-club.lu/~jaj/code/manaplus.tar.gz > > Would somebody like to commit this? > I discussed with upstream and they are interested in including the > patches in the next release. Reads good to me, didn't knew the BSD4_4 #define which could be useful in lots of places, if this is realy common to all bsds... Minor nit : DISTFILES is not needed, we generally do DISTNAME + EXTRACT_SUFX=.tar.bz2. If anyone wants to import it, ok by me. Landry
