On Sat, January 1, 2011 22:32, Ingo Schwarze wrote:
> Hi Kirill,
>
> Kirill Bychkov wrote on Sat, Jan 01, 2011 at 10:20:03PM +0300:
>
>> This patch adds rc.d script for apcupsd
>> and updates WANTLIB abd LIB_DEPENDS.
>
> [...]
>> Index: pkg/apcupsd.rc
>> ===================================================================
>> RCS file: pkg/apcupsd.rc
>> diff -N pkg/apcupsd.rc
>> --- /dev/null        1 Jan 1970 00:00:00 -0000
>> +++ pkg/apcupsd.rc   1 Jan 2011 19:14:29 -0000
>> @@ -0,0 +1,17 @@
>> +#!/bin/sh
>> +#
>> +# $OpenBSD$
>> +
>> +. /etc/rc.d/rc.subr
>> +
>> +daemon=${TRUEPREFIX}/sbin/apcupsctl
>
> This is wrong.
> Those variables required by the top-level code in rc.subr,
> in particular daemon*, have to be set before calling rc.subr.

Oh, thanks for hint. Attached is reworked diff.

>
> Yours,
>   Ingo
>
> DISCLAIMER:
> I'm not a regular porter, so look out for comments from
> other people as well.
>

Well, I've looked at mysql port for example.

>

Attachment: apcupsd.diff
Description: Binary data

Reply via email to