On 07/15/10 17:22, David Coppa wrote:
> On Thu, Jul 15, 2010 at 4:27 PM, Christopher Zimmermann
> <[email protected]> wrote:
>
> Some comments.
>
>>
>> Index: ports/devel/libyajl//Makefile
>
> If the pkgname is yajl, then this should go under devel/yajl.
ok. Then probably the package name should be changed to libyajl,
since it is a library?
>
> these WANTLIB and LIB_DEPENDS are bogus. Have you done cut'n'paste
> from another port?
> yajl only depends on the c library.
yep, that's what I've done. I just forgot to remove the wrong
dependencies.
>> +fetch:
>> + ftp -o ${FULLDISTDIR}/${DISTNAME}${EXTRACT_SUFX} \
>> + ${GITHUB_TARBALL}${V}
>> +
>> +post-extract:
>> + mv ${WRKDIR}/lloyd-yajl-* ${WRKDIR}/${DISTNAME}
>
> This is ugly: use WRKDIST instead.
ok. I thought the git SHA sum was ugly, because one would have to
change the SHA sum and the version number when upstream releases
a new version.
> I've attached a polished tarball to this mail.
fine, thanks!
anything else that needs to be done to get this into CVS?
What about the problem with fetching from github?
As it is now, one has to run `make fetch` before `make package`.
Christopher
