On Thu, Jun 24, 2010 at 02:44:02PM +0200, Nicolas Szalay wrote:
> Hello,
>
> I've made these 2 ports with precious help from Landry so I share them
> with po...@.
I've had a quick look, some more comments :
ruby-stomp autogenerates its documentation here, and installs it in
lib/ruby/gems/${MODRUBY_REV}/doc/${DISTNAME}/{rdoc,ri}. Run make
update-plist to integrate that. DESCR could use some love..
I'm not in ruby ports, so if someone could check how it's usually
done.. bernd ? :)
Why not porting 1.1, which is apparently the latest on rubyforge ?
For mcollective:
- lowercase COMMENT
- patch-etc_server_cfg_dist is wrong, we dont hardcode paths like that
in configuration files. patch it so that it gets ${PREFIX}, then use
${SUBST_CMD} during pre-install (or post-patch) to replace it by the
regular value. And dont forget to rm .orig/.beforesubst files so that
they don't end up in PLIST after make update-plist.
make-plist: pkg/PLIST may contain patched file
share/examples/mcollective/server.cfg.dist.orig
pkg/PLIST changed
smth like:
post-patch:
${SUBST_CMD} ${WRKSRC}/etc/server.cfg.dist
rm -f ${WRKSRC}/etc/server.cfg.dist.{orig,beforesubst}
I'm not sure we need the PLACEHOLDER files ...
Landry
