On Mon, Oct 12, 2009 at 03:26:21PM +0200, David Coppa wrote:
>
> Hi,
>
> This diff updates gnome-mplayer & gecko-mediaplayer to the latest 0.9.8.
> It also includes some necessary bugfixes from upstream svn.
>
> For gnome-mplayer, I've forced the use of mplayer software mixer,
> because It's the only working way to adjust the volume with sndio
> backend.
>
> I've done this by adding:
>
> if (!softvol && ao != NULL && g_ascii_strncasecmp(ao, "sndio",
> strlen("sndio")) == 0)
> softvol = TRUE;
>
> In main.c
>
> Maybe this can be removed and a warning in pkg/MESSAGE can be added instead
> (Flag "Mplayer Software Volume Control Enabled" under Preferences -> MPlayer).
I didn't look at it, but in general, if it's already an option, then you
could patch the default choice for the option instead of adding a hack
to the code. maybe a message for people who are updating would be nice
too.
--
[email protected]
SDF Public Access UNIX System - http://sdf.lonestar.org
