On Sat, Sep 26, 2009 at 07:15:56PM +0200, Floor Terra wrote:
> Hi,
>
> I had this port for a while but did not submit it yet.
> Feedback is welcome. This is my first port.
Welcome aboard!
I had this port for a while too, I think I submitted it once
back in 2008 (it's been on my web site since then). Suggestions:
category should probably be math, not databases. It's not really
what we think of as a database format; it's designed for scientific
data, commonly used for e.g medical images, mri data, ...
Look at where netcdf wound up, for example. You can have more than
one category in CATEGORIES, but the primary (hence the directory name)
should be math.
HOMEPAGE should not be the download page, but a place you can get
information about the program. MASTER_SITES is the download page.
You can say MASTER_SITES = ${HOMEPAGE}/HDF5/current/src/
if that makes sense, but they are not the same.
Check the licensing on the included sflib. I didn't like it so I used
CONFIGURE_ARGS+= ${CONFIGURE_SHARED} --without-sflib
Maybe others, but that's what I spotted on first inspection.
