On 2009/07/28 11:46, Giovanni Bechis wrote:
> Stuart Henderson wrote:
> >I'm not opposed to X dep's where it makes sense, but I think this is
> >one occasion where it doesn't really give any benefits, and somebody
> >who is actually trying to install tkmib is unlikely to think of
> >p5-SNMP when they try and decide which package they need to install
> >to get it.
> Some comments on this diff ?
slightly tweaked;
- change PKGNAME-x11 to tkmib (I think it's more descriptive
that way)
- adjust COMMENT-x11
- add an @conflict marker to PLIST-x11 since it can't be installed
alongside earlier versions of the net-snmp package
Index: Makefile
===================================================================
RCS file: /cvs/ports/net/net-snmp/Makefile,v
retrieving revision 1.38
diff -u -p -r1.38 Makefile
--- Makefile 13 Feb 2009 09:39:38 -0000 1.38
+++ Makefile 28 Jul 2009 10:06:02 -0000
@@ -2,11 +2,13 @@
COMMENT-main= extendable SNMP implementation
COMMENT-perl= SNMP modules for Perl
+COMMENT-x11= graphical SNMP MIB browser
V= 5.4.2.1
DISTNAME= net-snmp-${V}
-PKGNAME-main= ${DISTNAME}p1
+PKGNAME-main= ${DISTNAME}p2
PKGNAME-perl= p5-SNMP-${V}p0
+PKGNAME-x11= tkmib-${V}
SHARED_LIBS= netsnmp 8.0 \
netsnmpagent 8.1 \
netsnmphelpers 8.0 \
@@ -26,9 +28,11 @@ PERMIT_DISTFILES_CDROM= Yes
PERMIT_DISTFILES_FTP= Yes
WANTLIB-main= c crypto kvm m perl util wrap
-MULTI_PACKAGES= -main -perl
+MULTI_PACKAGES= -main -perl -x11
LIB_DEPENDS-perl=
netsnmptrapd,netsnmpmibs,netsnmphelpers,netsnmpagent,netsnmp::net/net-snmp,-main
+RUN_DEPENDS-x11= ::net/net-snmp,-perl \
+ ::x11/p5-Tk
NET_SNMP_MIB_LIST= host disman/event-mib smux mibII/mta_sendmail
Index: patches/patch-local_tkmib
===================================================================
RCS file: patches/patch-local_tkmib
diff -N patches/patch-local_tkmib
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-local_tkmib 28 Jul 2009 10:06:02 -0000
@@ -0,0 +1,8 @@
+$OpenBSD$
+--- local/tkmib.orig Thu Jul 16 09:07:45 2009
++++ local/tkmib Thu Jul 16 09:08:01 2009
+@@ -1,4 +1,3 @@
+-#!/usr/bin/perl
+ #!/usr/bin/perl -w
+
+ require 5;
Index: pkg/DESCR-x11
===================================================================
RCS file: pkg/DESCR-x11
diff -N pkg/DESCR-x11
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ pkg/DESCR-x11 28 Jul 2009 10:06:02 -0000
@@ -0,0 +1 @@
+Some x11 utilities to view snmp data.
Index: pkg/PLIST-main
===================================================================
RCS file: /cvs/ports/net/net-snmp/pkg/PLIST-main,v
retrieving revision 1.6
diff -u -p -r1.6 PLIST-main
--- pkg/PLIST-main 12 Oct 2008 08:21:21 -0000 1.6
+++ pkg/PLIST-main 28 Jul 2009 10:06:02 -0000
@@ -26,7 +26,6 @@ bin/snmpinform
@bin bin/snmpusm
@bin bin/snmpvacm
@bin bin/snmpwalk
-bin/tkmib
bin/traptoemail
include/net-snmp/
include/net-snmp/agent/
@@ -218,7 +217,6 @@ lib/libnetsnmptrapd.la
@man man/man1/snmpusm.1
@man man/man1/snmpvacm.1
@man man/man1/snmpwalk.1
-...@man man/man1/tkmib.1
@man man/man1/traptoemail.1
@man man/man3/add_mibdir.3
@man man/man3/add_module_replacement.3
Index: pkg/PLIST-x11
===================================================================
RCS file: pkg/PLIST-x11
diff -N pkg/PLIST-x11
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ pkg/PLIST-x11 28 Jul 2009 10:06:02 -0000
@@ -0,0 +1,4 @@
+...@comment $OpenBSD$
+...@conflict net-snmp-<5.4.2.1p2
+bin/tkmib
+...@man man/man1/tkmib.1
