On Sat, Apr 25, 2009 at 02:48:42PM +0200, Thomas Pfaff wrote:
> This diff adds an sndio backend to audio/flite.
>
> After patching, remove the now empty patches/patch-configure
> and patches/patch-src_audio_au_sun.c. Tested OK on amd64.
>
> I'll ask upstream for inclusion unless anyone experience
> problems or have any comments.
>
> Oh, and you might need to increase your ulimit -d for this
> to compile ...
>
> Comments, OK?
>
works on i386, and the sndio bits look very good.
(see below for nitpicking :).
> + sio_initpar (&par); switch (fmt) {
> + case CST_AUDIO_LINEAR16:
> + par.bits = 16;
> + par.sig = 1;
> + par.le = SIO_LE_NATIVE;
> + break;
> + case CST_AUDIO_LINEAR8:
> + par.bits = 8;
> + par.sig = 0;
> + par.le = 0;
^^^^^^
par.le is not used as bits <= 8
...
> +
> + /* 250 ms buffer */
> + par.appbufsz = par.rate / 4;
> +
afaiu, there's no need to set the buffer size because there
are no latency constraints; 250ms doesn't hurt though.
-- Alexandre
