On Mon, Mar 16, 2009 at 09:56:49AM +0100, Pierre Riteau wrote:
> On Sun, Mar 15, 2009 at 03:56:55PM +0100, Landry Breuil wrote:
> > On Sat, Mar 14, 2009 at 11:37:00AM +0100, Pierre Riteau wrote:
> > > Update to sdlmess 0.130.
> > 
> > Comments goes for sdlmame & sdlmess :
> > WANTLIB lacks dbus-1 & gio-2.0
> > I'd rather see src/osd/sdl/sdlprefix.h patched to add
> > || defined(__OpenBSD__) (and forward the diff upstream) instead of lying
> > and pretend SDLMAME_FREEBSD is defined. If possible, make upstream
> > change this define to a more generic SDLMAME_BSD ... like
> > SDLMAME_DARWIN/SDLMAME_WIN32/SDLMAME_LINUX.
> > And forward sdl.mak patch too :)
> 
> Fixed. I will forward the diffs ASAP.
> I also removed testkeys from the installed files, it's not very useful
> for the end user (it is used to create keymap files for SDL).
> And I fixed the makefile to stop using -O3, as reported by Jacob.
> 
> > I didn't really manage to see the difference between sdlmame and
> > sdlmess, but as it's two different tarballs (sdlmess is twice bigger),
> > yeah that's correct to do two separate ports. But maybe install the
> > 'common binaries' both prefixed by where they came as done for mess.
> 
> sdlmess uses sdlmame's code, adds modules to emulate home consoles and
> computers, and doesn't build mame modules.
> It should be possible to build sdlmame from sdlmess source
> (just need to change the TARGET in the makefile), but using sdlmame's
> tarball makes it easier to test the interim releases (sdlmame-0.XXXuY):
> sdlmess is only updated for new stable releases.
> 
> I changed the name of the common binaries to use a suffix instead of a
> prefix. Makes it easier to find them with autocompletion.
> 
> I've also looked at the last 4 releases and the common binaries source
> is the same. I will see about multi-packaging them.
> 
> > Other than that, looks good so far.. if only it didn't take HOURS to
> > build. I suppose you tried gcc3, and it miserably fails...
> 
> Yep, it doesn't work. And I remember upstream reporting code generation
> bugs on old gcc releases, so they recommend gcc4+.
> 
> > Going to import both soon, after you send the fixes i mentioned :)
> > If anyone is interested to make it work/tested & enabled on ppc/sparc64,
> > see with pierre :)
> > 
> > Landry
> 
> Thank you for the review Landry :)
> 
> If anyone want to test on ppc, drop me a mail since you need a small
> patch. And making it work on sparc64 is on my todo list.
> 
> Attached is a new tarball, plus a diff from the old tarball to help
> review.

New version which RUN_DEPENDS on sdlmame-tools.

Attachment: sdlmess-0.130v3.tar.gz
Description: application/tar-gz

Reply via email to