On Wed, Apr 2, 2008 at 4:10 PM, Mike Erdely <[EMAIL PROTECTED]> wrote: > For what it's worth, that section of code was wrapped in: > #ifdef __MINGW32__ > char *strdup... > #endif /* def __MINGW32__ */
Right, that's why I said: > > (Of course, OpenBSD provides strdup in libc, so > > this code isn't used, patched or not.) I noticed the "result != NULL" check in the context before the strlcpy change while quickly reviewing the diff, and thought it was suspicious. After investigating further to confirm that it's a bug (were someone to try to use it on mingw32 after porting strlcpy...), I thought I'd just point it out as an example of how carelessly replacing strcpy with strlcpy can break ports.
