On Wed, Mar 26, 2008 at 10:32:45PM +0000, Niall O'Higgins wrote:
> Tested on i386 and amd64.
>
> http://niallo.net/pycha-port.tar.gz
Looks good; I'd add SUBST_VARS+= VERSION (to clean up future plist
updates). Also, the regress suite seems to work, so I'd enable that
and add REGRESS_DEPENDS. When depending on Python ports, we usually
use RUN_DEPENDS rather than LIB_DEPENDS, too. Lastly, the
(cat|man)3f directories in PLIST shouldn't be there -- it seems like
your copy of /etc/mtree/BSD.local.dist is a bit out of date.
With regress enabled, passes on i386.
Above changes in a diff at:
http://www.lfod.us/files/ports/pycha.diff
Thanks!
--
o--------------------------{ Will Maier }--------------------------o
| web:.......http://www.lfod.us/ | [EMAIL PROTECTED] |
*------------------[ BSD Unix: Live Free or Die ]------------------*
diff -x .hg* -x *log -Naur ../pycha-orig/Makefile ./Makefile
--- ../pycha-orig/Makefile Wed Mar 26 16:54:46 2008
+++ ./Makefile Wed Mar 26 20:20:24 2008
@@ -19,9 +19,18 @@
MASTER_SITES= http://pypi.python.org/packages/source/p/pycha/
MODULES= lang/python
-LIB_DEPENDS= ::graphics/py-cairo
USE_LIBTOOL= Yes
USE_X11= Yes
MODPY_SETUPTOOLS=Yes
+
+RUN_DEPENDS+= ::graphics/py-cairo
+REGRESS_DEPENDS=${RUN_DEPENDS}
+
+SUBST_VARS+= VERSION
+
+do-regress: fake
+ @cd ${WRKSRC}/tests && ${MAKE_ENV} \
+ PYTHONPATH=${WRKINST}${MODPY_SITEPKG} \
+ ${MODPY_BIN} ./runner.py
.include <bsd.port.mk>
diff -x .hg* -x *log -Naur ../pycha-orig/pkg/PLIST ./pkg/PLIST
--- ../pycha-orig/pkg/PLIST Wed Mar 26 16:53:34 2008
+++ ./pkg/PLIST Wed Mar 26 19:57:34 2008
@@ -1,11 +1,11 @@
@comment $OpenBSD: PLIST,v 1.3 2007/03/26 20:32:11 alek Exp $
lib/python${MODPY_VERSION}/site-packages/pycha/
-lib/python${MODPY_VERSION}/site-packages/pycha-0.3.0-py${MODPY_VERSION}.egg-info/
-lib/python${MODPY_VERSION}/site-packages/pycha-0.3.0-py${MODPY_VERSION}.egg-info/PKG-INFO
-lib/python${MODPY_VERSION}/site-packages/pycha-0.3.0-py${MODPY_VERSION}.egg-info/SOURCES.txt
-lib/python${MODPY_VERSION}/site-packages/pycha-0.3.0-py${MODPY_VERSION}.egg-info/dependency_links.txt
-lib/python${MODPY_VERSION}/site-packages/pycha-0.3.0-py${MODPY_VERSION}.egg-info/top_level.txt
-lib/python${MODPY_VERSION}/site-packages/pycha-0.3.0-py${MODPY_VERSION}.egg-info/zip-safe
+lib/python${MODPY_VERSION}/site-packages/pycha-${VERSION}-py${MODPY_VERSION}.egg-info/
+lib/python${MODPY_VERSION}/site-packages/pycha-${VERSION}-py${MODPY_VERSION}.egg-info/PKG-INFO
+lib/python${MODPY_VERSION}/site-packages/pycha-${VERSION}-py${MODPY_VERSION}.egg-info/SOURCES.txt
+lib/python${MODPY_VERSION}/site-packages/pycha-${VERSION}-py${MODPY_VERSION}.egg-info/dependency_links.txt
+lib/python${MODPY_VERSION}/site-packages/pycha-${VERSION}-py${MODPY_VERSION}.egg-info/top_level.txt
+lib/python${MODPY_VERSION}/site-packages/pycha-${VERSION}-py${MODPY_VERSION}.egg-info/zip-safe
lib/python${MODPY_VERSION}/site-packages/pycha/__init__.py
lib/python${MODPY_VERSION}/site-packages/pycha/__init__.pyc
lib/python${MODPY_VERSION}/site-packages/pycha/bar.py
@@ -20,5 +20,3 @@
lib/python${MODPY_VERSION}/site-packages/pycha/pie.pyc
lib/python${MODPY_VERSION}/site-packages/pycha/scatter.py
lib/python${MODPY_VERSION}/site-packages/pycha/scatter.pyc
-man/cat3f/
-man/man3f/
