On Wed 2007.11.14 at 03:43 +0200, Soner Tari wrote: > > - remove that #comment > Uhm, which one?
oh, that one about the original - go ahead and mention here on ports@ so people if that's the intention. > > - probably just belongs in mail category > Done (I'm still not sure, it's a proxy, but anyway). yea, well...maybe others will have a comment too ;) > > - hardcoding /usr/local in patches... > Done. i think that i may have been misleading in my first reply. sthen@ gave a much more accurate and verbose comment. you'll want to _not_ hardcode paths, but rather substitute - see his mail for the example. > > i think there's more, but that's a start. > > Did fix some more myself already. But I am sure there is more. > > Please see the new package attached. Any ideas again? great, and yes i have another comment ;) i'm confused to the purpose of files/p3scan-config - the packaging tools will take care of all this for you. check out the different markers for PLIST (e.g. @sample) - lots of ports use them so reference them for examples. > (Btw, the original Makefile-ripmime patches were from 1.1 port, I did > many changes, but is it me or is this Makefile-ripmime too ugly to fix?) well honestly, i haven't gone through all the patches yet - by the time you re-write/patch the makefiles, it might be simpler to just roll your own - but again, i haven't looked too carefully here, yet. cheers, okan
