Am Fri, Sep 05, 2025 at 03:40:22PM +0200 schrieb Antoine Jacoutot:
> On Fri, Sep 05, 2025 at 09:56:43AM +0200, Martin Ziemer wrote:
> > Am Mon, Aug 25, 2025 at 10:53:07AM +0200 schrieb Martin Ziemer:
> > > This patch updates gnuchess from 6.2.11 to 6.3.0.
> > > 
> > > Had to manually copy gnuchess.ini since it was not taken by default.
> > > 
> > > Tested on amd64.
> > 
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/games/gnuchess/Makefile,v
> > diff -u -p -r1.53 Makefile
> > --- Makefile        30 Apr 2025 10:24:24 -0000      1.53
> > +++ Makefile        22 Aug 2025 07:08:50 -0000
> > @@ -1,6 +1,6 @@
> >  COMMENT=   chess program
> >  
> > -DISTNAME=  gnuchess-6.2.11
> > +DISTNAME=  gnuchess-6.3.0
> >  DISTFILES= ${DISTNAME}.tar.gz book_1.02.pgn.gz
> >  
> >  CATEGORIES=        games
> > @@ -24,6 +24,7 @@ CONFIGURE_STYLE=  gnu
> >  
> >  README=                    ${WRKSRC}/README
> >  BOOK_FILE=         ${WRKSRC}/src/book.bin
> > +GNUCHESS_INI=              ${WRKSRC}/doc/gnuchess.ini
> 
> I don't think we need this.
Stuart Henderson also said he sees no point in variables only
referenced once. (I just used the same method as for the other two
files in this Makefile)

At the end is a diff removing all three Variables.

If the last commit is already build, the REVISION would need to be added.

The file itself should be shipped, as gnuchess shows warnings like the
line below without any ini file:
  Can't open file "(null)": Bad address - using defaults
> 
> 
> >  post-build:
> >             cd ${WRKSRC}/src && ln -sf ../../book_1.02.pgn
> > @@ -31,6 +32,7 @@ post-build:
> >  
> >  post-install:
> >             ${INSTALL_DATA_DIR} ${PREFIX}/share/gnuchess
> > +           ${INSTALL_DATA} ${GNUCHESS_INI} ${PREFIX}/share/gnuchess
> >             ${INSTALL_DATA} ${BOOK_FILE} ${PREFIX}/share/gnuchess
> >             ${INSTALL_DATA_DIR} ${PREFIX}/share/doc/gnuchess
> >             ${INSTALL_DATA} ${README} ${PREFIX}/share/doc/gnuchess
> > Index: distinfo
> > ===================================================================
> > RCS file: /cvs/ports/games/gnuchess/distinfo,v
> > diff -u -p -r1.17 distinfo
> > --- distinfo        30 Apr 2025 10:24:24 -0000      1.17
> > +++ distinfo        22 Aug 2025 07:08:50 -0000
> > @@ -1,4 +1,4 @@
> >  SHA256 (book_1.02.pgn.gz) = 3qx37bBhpZJJoZ3rA9o0nK4FHlJSemy1r4CNk5jTLUQ=
> > -SHA256 (gnuchess-6.2.11.tar.gz) = 
> > 2BFA7qXGnRSwz7Y4FtS0yeGPulH1Jn3lsVOfRok56b0=
> > +SHA256 (gnuchess-6.3.0.tar.gz) = 
> > Cze+wgmMKtaVt0Q+XXlE3G3IKE+NAfzDC9uU3QM8ojo=
> >  SIZE (book_1.02.pgn.gz) = 26265281
> > -SIZE (gnuchess-6.2.11.tar.gz) = 811399
> > +SIZE (gnuchess-6.3.0.tar.gz) = 835620
> > Index: pkg/PLIST
> > ===================================================================
> > RCS file: /cvs/ports/games/gnuchess/pkg/PLIST,v
> > diff -u -p -r1.14 PLIST
> > --- pkg/PLIST       11 Mar 2022 19:04:29 -0000      1.14
> > +++ pkg/PLIST       22 Aug 2025 07:08:50 -0000
> > @@ -25,6 +25,7 @@ share/locale/it/LC_MESSAGES/gnuchess.mo
> >  share/locale/nb/LC_MESSAGES/gnuchess.mo
> >  share/locale/nl/LC_MESSAGES/gnuchess.mo
> >  share/locale/pt_BR/LC_MESSAGES/gnuchess.mo
> > +share/locale/ro/LC_MESSAGES/gnuchess.mo
> >  share/locale/sr/LC_MESSAGES/gnuchess.mo
> >  share/locale/sv/LC_MESSAGES/gnuchess.mo
> >  share/locale/uk/LC_MESSAGES/gnuchess.mo
> > 
> 
> -- 
> Antoine
> 

Index: Makefile
===================================================================
RCS file: /cvs/ports/games/gnuchess/Makefile,v
diff -u -p -u -p -r1.54 Makefile
--- Makefile    5 Sep 2025 11:51:18 -0000       1.54
+++ Makefile    5 Sep 2025 13:54:38 -0000
@@ -22,19 +22,15 @@ BUILD_DEPENDS=      devel/help2man
 
 CONFIGURE_STYLE=       gnu
 
-README=                        ${WRKSRC}/README
-BOOK_FILE=             ${WRKSRC}/src/book.bin
-GNUCHESS_INI=          ${WRKSRC}/doc/gnuchess.ini
-
 post-build:
                cd ${WRKSRC}/src && ln -sf ../../book_1.02.pgn
                cd ${WRKSRC}/src && ./gnuchess --addbook book_1.02.pgn
 
 post-install:
                ${INSTALL_DATA_DIR} ${PREFIX}/share/gnuchess
-               ${INSTALL_DATA} ${GNUCHESS_INI} ${PREFIX}/share/gnuchess
-               ${INSTALL_DATA} ${BOOK_FILE} ${PREFIX}/share/gnuchess
+               ${INSTALL_DATA} ${WRKSRC}/doc/gnuchess.ini 
${PREFIX}/share/gnuchess
+               ${INSTALL_DATA} ${WRKSRC}/src/book.bin ${PREFIX}/share/gnuchess
                ${INSTALL_DATA_DIR} ${PREFIX}/share/doc/gnuchess
-               ${INSTALL_DATA} ${README} ${PREFIX}/share/doc/gnuchess
+               ${INSTALL_DATA} ${WRKSRC}/README ${PREFIX}/share/doc/gnuchess
 
 .include <bsd.port.mk>

Reply via email to