we are currently preparing for 7.7 release and not doing usual commits,
but a few comments based on reading your port in the meantime.
On 2025/04/07 19:35, Sören Tempel wrote:
> Hello!
>
> Attached, please find a port for xandikos, which is a minimal,
> Git-backed CalDav server. It offers high compatibility with various
> CalDav standards, but does not support a multi-user setup or CalDAV
> scheduling extensions.
>
> In my view, it is more minimal and yet more standard-conforming than the
> existing radicale2 port and should thus be considered for inclusion in
> the ports tree.
In general: seems reasonable to add this software and I think only a few
changes needed.
pkg/README:
: xandikos listens by default on localhost:8080 without authentication.
Would be useful to show how to change the port - is it via flags or
config file?
Maybe repeat the fact that it only supports a single user account per
daemon instance here too, in case someone didn't understand the "not
nulti-user" from DESCR.
: MODPY_DISTV = 0.2.12
: DISTNAME = xandikos-${MODPY_DISTV}
: DISTFILES = ${DISTNAME}{v${MODPY_DISTV}}.tar.gz
: PKGNAME = ${DISTNAME:L}
...
: SITES = https://github.com/jelmer/xandikos/archive/
don't use SITES with a github /archive/ URL.
is there a particular reason to use the github git-archive?
- if not, the pypi distfile is normally preferred (set MODPY_PI=Yes,
remove DISTFILES, also the PKGNAME is not useful as the default setting
works - :L is "lowercase this var" which is already lower case - so
remove PKGNAME too). the distfile will differ so "make clean=dist" and
"make makesum".
- if there is (e.g. if tests are only in the github one) then instead
drop SITES, DISTFILES, DISTNAME, PKGNAME, add GH_ACCOUNT=jelmer,
GH_PROJECT=xandikos, GH_TAGNAME=v${MODPY_DISTV}.
: REVISION = 0
no REVISION in a new port
: SUBST_VARS = MODPY_SITEPKG
no need to set this, make show=SUBST_VARS will show that it's already
included.
: RUN_DEPENDS = devel/py-dulwich${MODPY_FLAVOR} \
: www/py-aiohttp${MODPY_FLAVOR} \
: textproc/py-defusedxml${MODPY_FLAVOR} \
: devel/py-icalendar${MODPY_FLAVOR} \
: www/py-jinja2${MODPY_FLAVOR} \
: textproc/py-vobject${MODPY_FLAVOR}
we stopped using ${MODPY_FLAVOR} after 7.6.
: MODPY_PYTEST = Yes
set by default, can be dropped
I have not yet run it, only read through.
