On Tue, Mar 25, 2025 at 10:22:42AM +0000, Stuart Henderson wrote: > On 2025/03/25 10:03, Mikolaj Kucharski wrote: > > Hi. > > > > I am addressing two issues here. The setproctitle problem in the rc.d(8) > > scripts I reported in the past https://marc.info/?t=170056003800006&r=1&w=2 > > and change for pexp works for me. > > definitely makes sense to make this consistent. > > > Second is, salt needs tornado. > > There are some others listed in requirements/base.txt (aiohttp and a > handful more), any idea if they're needed too?
I would add aiohttp, even though I think code path to use it is not triggered by default configuration. Picking random machine, which has salt installed arleady, but not a lot of other packages, it's below 3.5MB of packages and 11.0MB after unpacking. For me this is acceptable trade off, to pull in aiohttp. # grep -lR aiohttp lib/python3.12/site-packages/salt/transport/__pycache__/ws.cpython-312.pyc lib/python3.12/site-packages/salt/transport/ws.py lib/python3.12/site-packages/salt-3007.1-py3.12.egg-info/requires.txt man/man7/salt.7 It looks like ws transport needs it, which is not the default. # env PKG_CACHE=/tmp/c/ pkg_add -nI py3-aiohttp quirks-7.102 signed on 2025-03-24T20:23:16Z py3-aiohttp-3.11.14:py3-frozenlist-1.5.0: ok py3-aiohttp-3.11.14:py3-aiosignal-1.3.2: ok py3-aiohttp-3.11.14:py3-propcache-0.3.0: ok py3-aiohttp-3.11.14:py3-multidict-6.1.0p0: ok py3-aiohttp-3.11.14:py3-yarl-1.18.0p0: ok py3-aiohttp-3.11.14:libcares-1.34.3p0: ok py3-aiohttp-3.11.14:py3-cares-4.5.0: ok py3-aiohttp-3.11.14:py3-aiodns-3.2.0p0: ok py3-aiohttp-3.11.14:py3-aiohappyeyeballs-2.6.1: ok py3-aiohttp-3.11.14:py3-attrs-25.3.0: ok py3-aiohttp-3.11.14: ok # du -sh /tmp/c/ 3.1M /tmp/c/ About the rest of depds from base.txt I don't know. Command salt --versions-report shows what is installed and what is missing from there. I think with the rest I would deal on case by case basis. > tweaked diff: > > - tidy whitespace after the whole-tree MODPY_DISTV change > - use MODPY_PYBUILD instead of obsolete MODOY_SETUPTOOLS > - sort RUN_DEPENDS by the order in base.txt (I didn't add the missing > ones, I don't know salt well enough to know if they're needed) > - start REVISION at 0 > I didn't had a time to test your diff(s) yet, Stuart. -- Regards, Mikolaj
