A bit late to the party...
On Sunday, March 2, 2025 at 11:47:13 a.m. EST, Jeremie Courreges-Anglas
<j...@wxcvbn.org> wrote:
The "./jimsh0" case above is actually the executable name of a
stripped version of jimtcl shipped as autosetup/jimsh0.c in the sqlite
tarball. The first other tclsh executable in the list is going to be
used if present, with a fallback on compiling and using jimsh0. IMO
we always want to use the same interpreter, and can't take the risk of
a picked up version being junked by dpb(1) in bulk builds, no matter
the length of the race window.
You could patch out the alternatives and always use the jimsh0.c
fallback. But adding a BUILD_DEPENDS on lang/tcl looks sane. It
doesn't bring any other BUILD_DEPENDS/LIB_DEPENDS and would be the
usual thing to do.
That, and setting autosetup_tclsh=${MODTCL_BIN} is the best way to go, imo.
I don't think the patch to autosetup/autosetup-find-tclsh is necessary.
(The port doesn't have any patches, which is nice.)
Updated diff below:
- add bdep on lang/tcl, let the tcl module decide which version to use
but force the picked up version to be used in autosetup.
Alternately we could choose the tcl version independently of the
defaults in tcl.port.mk
MODTCL_VERSION=8.6
Would be preferable.
Also, in the diff, autosetup_tclsh={MODTCL_BIN} is missing the $.
Stu
